feat: changed the tracker for a more generic class

rsksmart · Jan 9, 2025 · 57822e0 · 57822e0
1 parent 3efcf62
commit 57822e0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/rskj-core/src/main/java/co/rsk/peg/federation/FederationStorageProviderImpl.java b/rskj-core/src/main/java/co/rsk/peg/federation/FederationStorageProviderImpl.java
@@ -159,13 +159,13 @@ public Federation getOldFederation(FederationConstants federationConstants, Acti
             }
         );
 
-        oldFederationTracker.set(oldFederation, false);
+        oldFederationTracker.set(oldFederation);
         return oldFederationTracker.get();
     }
 
     @Override
     public void setOldFederation(Federation federation) {
-        oldFederationTracker.set(federation, true);
+        oldFederationTracker.setNew(federation);
     }
 
     @Override
@@ -190,13 +190,13 @@ public PendingFederation getPendingFederation() {
                 }
             );
 
-        pendingFederationTracker.set(pendingFederation, false);
+        pendingFederationTracker.set(pendingFederation);
         return pendingFederationTracker.get();
     }
 
     @Override
     public void setPendingFederation(PendingFederation federation) {
-        pendingFederationTracker.set(federation, true);
+        pendingFederationTracker.setNew(federation);
     }
 
     @Override

diff --git a/rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java b/rskj-core/src/main/java/co/rsk/peg/federation/FederationTracker.java
@@ -1,27 +1,31 @@
 package co.rsk.peg.federation;
 
 public class FederationTracker<T> {
-    private T federation;
+    private T value;
     private boolean modified = false;
 
     public boolean isModified() {
         return this.modified;
     }
 
     public T get() {
-        return this.federation;
+        return this.value;
     }
 
     public boolean isPresent() {
-        return this.federation != null;
+        return this.value != null;
     }
 
     public boolean hasBeenSet() {
         return this.isPresent() || this.isModified();
     }
 
-    public void set(T aFederation, boolean shouldSave) {
-        this.federation = aFederation;
-        this.modified = shouldSave;
+    public void setNew(T aValue) {
+        this.value = aValue;
+        this.modified = true;
+    }
+
+    public void set(T aValue) {
+        this.value = aValue;
     }
 }