Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format=2 style dependencies to generated package.cmake file #786

Conversation

NikolausDemmel
Copy link
Contributor

needed for catkin/catkin_simple#7

I opened this for indigo-devel, but it should probably be ported to all distros.

It only adds new cmake variables defined in the generated package.cmake file, so I would assume that this change is low risk.

@dirk-thomas
Copy link
Member

See catkin/catkin_simple#7 (comment) for a detailed description about the differences and the relationship between the tags in the manifest and the dependency variables available in CMake.

For these variable to be correctly interpretable I think there must be a CMake variable identifying the format version. Otherwise e.g. the test dependencies can't be used correctly. See REP 140:

test_depend now fulfills configuration and build-time test requirements in addition to the objects needed for running them.

Also currently some of the tests fail.

@NikolausDemmel
Copy link
Contributor Author

For these variable to be correctly interpretable It think there must be a CMake variable identifying the format version.

I'll add that (noone actually uses TEST_DEPENDS though; I just added it for completeness).

I'll fix the unit tests as well.

@dirk-thomas
Copy link
Member

@NikolausDemmel What is your timeline on this? I could look into it this afternoon to make sure it gets released before the major rebuild of Indigo / Jade. Otherwise it is commonly several months until the next catkin release (due to the huge overhead to rebuild all packages).

@NikolausDemmel
Copy link
Contributor Author

I'm out for dinner. I'll try to do it when I get home as beers permit. It should relly be straight forward changes, so if you are about to do a release, feel free to do it yourself if you have a spare cycle.

@dirk-thomas
Copy link
Member

I will take a look right now and post the progress here. Enjoy the 🍻

@dirk-thomas
Copy link
Member

I have created #787 which has the following differences compared to this:

  • add PACKAGE_FORMAT
  • updated the unit tests
  • make the generated code use deterministic order

Thank you for this patch. I reused it to start the other PR. Closing this though since it is superseded by #787.

@NikolausDemmel NikolausDemmel deleted the feature/format-2-package.cmake branch March 19, 2016 16:20
@NikolausDemmel
Copy link
Contributor Author

Awesome. The 🍻 had the better of me anyway. Thanks for addressing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants