Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: import filterFeatures from ProtGenerics #198

Merged
merged 2 commits into from
Jan 17, 2024
Merged

refactor: import filterFeatures from ProtGenerics #198

merged 2 commits into from
Jan 17, 2024

Conversation

jorainer
Copy link
Member

This PR imports the filterFeatures method from ProtGenerics (see also PR rformassspectrometry/ProtGenerics#18).

@jorainer jorainer requested a review from lgatto January 17, 2024 07:03
lgatto
lgatto requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@lgatto lgatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add an entry in the NEWS file, please.

@jorainer
Copy link
Member Author

Done.

@jorainer jorainer requested a review from lgatto January 17, 2024 08:37
@lgatto lgatto merged commit cb18cf3 into master Jan 17, 2024
2 checks passed
@lgatto
Copy link
Member

lgatto commented Jan 17, 2024

pushed to Bioc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgatto lgatto lgatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorainer @lgatto