Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DW UI tests to align with the latest Dashboard UI improvements #2160

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Update DW UI tests to align with the latest Dashboard UI improvements #2160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ods_ci/tests/Resources/Common.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@
${elements}= Get WebElements ${parent_element}
${text_list}= Create List
FOR ${element} IN @{elements}
${text}= Run Keyword And Ignore Error
${status} ${text}= Run Keyword And Ignore Error
... Get Element Attribute ${element} textContent
Append To List ${text_list} ${text}
Run Keyword If '${status}' == 'PASS' Append To List ${text_list} ${text}

Check warning

Code scanning / Robocop

'{{ statement_name }}' is deprecated since Robot Framework version {{ version }}, use '{{ alternative }}' instead Warning test

'Run Keyword If' is deprecated since Robot Framework version 5.*, use 'IF' instead
END
RETURN ${text_list}

Expand Down
1 change: 0 additions & 1 deletion ods_ci/tests/Resources/Page/DistributedWorkloads/WorkloadMetricsUI.resource
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Resource ../../Common.robot

*** Variables ***
${PROJECT_XP}= xpath=//div[text()='Project']
${DISTRIBUITED_WORKLOAD_METRICS_TITLE_XP}= xpath=//h1[text()="Distributed Workload Metrics"]
${DISTRIBUITED_WORKLOAD_METRICS_TEXT_XP}= xpath=//div[text()='Monitor the metrics of your active resources.']
${PROJECT_METRICS_TAB_XP}= xpath=//button[@aria-label="Project metrics tab"]
${WORKLOAD_STATUS_TAB_XP}= xpath=//button[@aria-label="Distributed workload status tab"]
Expand Down
6 changes: 4 additions & 2 deletions ods_ci/tests/Tests/0600__distributed_workloads/test-distributed-workloads-metrics-ui.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ Verify Workload Metrics Home page Contents
[Tags] RHOAIENG-4837
... Sanity DistributedWorkloads Training WorkloadsOrchestration
Open Distributed Workload Metrics Home Page
Wait For Dashboard Page Title Distributed Workload Metrics
Wait Until Element Is Visible ${DISTRIBUITED_WORKLOAD_METRICS_TEXT_XP} timeout=20
Wait Until Element Is Visible ${PROJECT_METRICS_TAB_XP} timeout=20
Page Should Contain Element ${DISTRIBUITED_WORKLOAD_METRICS_TITLE_XP}
Page Should Contain Element ${DISTRIBUITED_WORKLOAD_METRICS_TEXT_XP}
Page Should Contain Element ${PROJECT_XP}
Page Should Contain Element ${PROJECT_METRICS_TAB_XP}
Expand Down Expand Up @@ -143,9 +143,11 @@ Verify The Workload Metrics By Submitting Ray Workload
Open Distributed Workload Metrics Home Page
Select Distributed Workload Project By Name ${PRJ_TITLE}
Select Refresh Interval 15 seconds
# verifying workload metrics in Dark mode
Click Button xpath=//button[@aria-label="dark theme"]
Wait Until Element Is Visible ${DISTRIBUITED_WORKLOAD_RESOURCE_METRICS_TITLE_XP} timeout=20
Wait For Job With Status ${RAY_CLUSTER_NAME} Admitted 30
Wait For Job With Status ${RAY_CLUSTER_NAME} Running 180
Wait For Job With Status ${RAY_CLUSTER_NAME} Running 300

${cpu_requested} = Get CPU Requested ${PRJ_TITLE} ${LOCAL_QUEUE_NAME}
${memory_requested} = Get Memory Requested ${PRJ_TITLE} ${LOCAL_QUEUE_NAME} RayCluster
Expand Down
Loading