Update DW UI tests to align with the latest Dashboard UI improvements #2160
Conversation
Srihari1192
requested review from
sutaakar,
manosnoam,
jiripetrlik and
ChughShilpa
Robot Results
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ... Get Element Attribute ${element} textContent | ||
| Append To List ${text_list} ${text} | ||
| Run Keyword If '${status}' == 'PASS' Append To List ${text_list} ${text} |
Check warning
Code scanning / Robocop
'{{ statement_name }}' is deprecated since Robot Framework version {{ version }}, use '{{ alternative }}' instead Warning test
| ${DISTRIBUITED_WORKLOAD_METRICS_TITLE_XP}= xpath=//h1[text()="Distributed Workload Metrics"] | ||
| ${DISTRIBUITED_WORKLOAD_METRICS_TITLE_XP}= xpath=//h1[@data-testid="app-page-title"] |
There was a problem hiding this comment.
This makes the verification too common since every page has this app-page-title id.
Look at
It tries to verify that we're in Distributed Workload Metrics.
btw, maybe you can also test it with Wait For Dashboard Page Title Distributed Workload Metrics
There was a problem hiding this comment.
@manosnoam Thanks for reviewing. Added Wait For Dashboard Page Title Distributed Workload Metrics to verify
Srihari1192
force-pushed
the
RHOAIENG-17341
branch
from
2d033bb to
1593c59
Compare
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ChughShilpa, manosnoam, Srihari1192, sutaakar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manosnoam
merged commit 58b325d
into
red-hat-data-services:master
closes https://issues.redhat.com/browse/RHOAIENG-17341
Get All Text Under Elementmethod to ensure it returns a properly processed and accurate list of text values.