-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set up pre-release workflow #94
feat: set up pre-release workflow #94
Conversation
7307705
to
9c3f550
Compare
Looks like the failures here are some kind of bug likely due to older workflows, I've created #95 to upgrade everything and that seems to fix it. |
Those are probably showing up because of some settings in the PR merge settings/rules. I'll have a look. Actually, the test failure on node 14 seems legit. |
Looking at the logs I see it is using NPM 10, even though NPM 9 is installed explicitly. I am not quite sure why this is happening to be honest. |
It would be good to get this passing as well if possible. |
I'll check it out when I have some more time. Let's get #95 merged first just to make sure the actions or environment don't have anything to do with it. |
9bbaabe
to
bbb41c1
Compare
Pull Request Test Coverage Report for Build 11496894224Details
💛 - Coveralls |
I went ahead and removed @rolandjitsu this one should be good to go now, let me know what you think. |
.github/workflows/release.yml
Outdated
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
run: npx semantic-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's pin this down to whatever version semantic-release is on today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned it to ^24
that should prevent breaking changes, but still get us bug-fixes when needed.
Signed-off-by: Jon Koops <[email protected]>
bbb41c1
to
526d7a4
Compare
@rolandjitsu we should be good to go now, can I ask you for another review? |
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks! 🎉 |
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Sets up the release workflow with the latest conventions from semantic release. This includes a
beta
branch for pre-releases and NPM provenance.Does this PR introduce a breaking change?
Nope.
Other information
None.