Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set up pre-release workflow #94

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jonkoops
Copy link
Collaborator

What kind of change does this PR introduce?

  • Bug Fix
  • Feature
  • Refactoring
  • Style
  • Build
  • Chore
  • Documentation
  • CI

Did you add tests for your changes?

  • Yes, my code is well tested
  • Not relevant

If relevant, did you update the documentation?

  • Yes, I've updated the documentation
  • Not relevant

Summary
Sets up the release workflow with the latest conventions from semantic release. This includes a beta branch for pre-releases and NPM provenance.

Does this PR introduce a breaking change?
Nope.

Other information
None.

@jonkoops jonkoops force-pushed the semantic-release-beta branch 2 times, most recently from 7307705 to 9c3f550 Compare October 13, 2024 14:13
@jonkoops
Copy link
Collaborator Author

Looks like the failures here are some kind of bug likely due to older workflows, I've created #95 to upgrade everything and that seems to fix it.

@rolandjitsu
Copy link
Collaborator

rolandjitsu commented Oct 13, 2024

Looks like the failures here are some kind of bug likely due to older workflows, I've created #95 to upgrade everything and that seems to fix it.

Those are probably showing up because of some settings in the PR merge settings/rules. I'll have a look.

Actually, the test failure on node 14 seems legit.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@jonkoops
Copy link
Collaborator Author

Actually, the test failure on node 14 seems legit.

Looking at the logs I see it is using NPM 10, even though NPM 9 is installed explicitly. I am not quite sure why this is happening to be honest.

@jonkoops jonkoops requested a review from rolandjitsu October 14, 2024 09:01
@rolandjitsu
Copy link
Collaborator

Actually, the test failure on node 14 seems legit.

Looking at the logs I see it is using NPM 10, even though NPM 9 is installed explicitly. I am not quite sure why this is happening to be honest.

It would be good to get this passing as well if possible.

@jonkoops
Copy link
Collaborator Author

Actually, the test failure on node 14 seems legit.

I'll check it out when I have some more time. Let's get #95 merged first just to make sure the actions or environment don't have anything to do with it.

@jonkoops jonkoops marked this pull request as draft October 21, 2024 10:06
@jonkoops jonkoops force-pushed the semantic-release-beta branch 2 times, most recently from 9bbaabe to bbb41c1 Compare October 23, 2024 08:08
@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11496894224

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11465547044: 0.0%
Covered Lines: 89
Relevant Lines: 89

💛 - Coveralls

@jonkoops
Copy link
Collaborator Author

I went ahead and removed semantic-release from the installed dependencies, as installing it bumped transitive dependencies that are used during the testing process, causing them to no longer be compatible with Node.js 14.

@rolandjitsu this one should be good to go now, let me know what you think.

@jonkoops jonkoops marked this pull request as ready for review October 23, 2024 08:11
@jonkoops jonkoops requested a review from rolandjitsu October 23, 2024 08:11
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npx semantic-release
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pin this down to whatever version semantic-release is on today.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned it to ^24 that should prevent breaking changes, but still get us bug-fixes when needed.

@jonkoops jonkoops force-pushed the semantic-release-beta branch from bbb41c1 to 526d7a4 Compare October 24, 2024 09:52
@jonkoops jonkoops requested a review from rolandjitsu October 24, 2024 09:53
@jonkoops
Copy link
Collaborator Author

@rolandjitsu we should be good to go now, can I ask you for another review?

@rolandjitsu rolandjitsu merged commit 72d5fa6 into react-dropzone:master Oct 25, 2024
6 checks passed
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonkoops jonkoops deleted the semantic-release-beta branch October 25, 2024 21:52
@jonkoops
Copy link
Collaborator Author

Thanks! 🎉

Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants