-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: drop UMD distribution from package #93
Conversation
@rolandjitsu considering this is another breaking change this will likely trigger the semantic release bot to do a |
Looks like setting up a |
Pull Request Test Coverage Report for Build 11540817160Details
💛 - Coveralls |
I can. We also need the right config in the workflows to allow running from beta and a releases config file. This is an example of a release config that allows beta releases and maintenance branch releases: plugins:
- "@semantic-release/commit-analyzer"
- "@semantic-release/release-notes-generator"
- "@semantic-release/gitlab"
branches:
- "master"
- "+([0-9])?(.{+([0-9]),x}).x"
- name: "beta"
prerelease: "rc" The above makes RC releases, but we can change to release as The release workflow also needs to change to something like: on:
push:
branches:
- master
- "[0-9]+.[0-9]+.x"
- beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Set up a pre-release workflow under #94, once that is merged we can set up the |
BREAKING CHANGE: removes the UMD distribution from the package Signed-off-by: Jon Koops <[email protected]>
This one is ready to be merged, I've rebased it against the |
Ok. Gonna have a look now. |
🎉 This PR is included in version 2.0.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: removes the UMD distribution from the package
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Removes the UMD distribution from the package in favor of using the module variant directly. This also removes the need to carry Rollup as a dependency. Documentation has also been cleaned up to reflect these changes.
Does this PR introduce a breaking change?
Yes, the UMD distrubution will no longer work, users should replace it with a direct import instead.
Other information
None.