-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve issue with boundary condition in depletion approximation #253
Conversation
Please note that `devpy` will soon be renamed to `spin` due to PyPi name availability.
Pin devpy and update commands to v0.1 API
also fix devpy issues
Codecov Report
@@ Coverage Diff @@
## develop #253 +/- ##
===========================================
- Coverage 57.12% 57.07% -0.06%
===========================================
Files 103 103
Lines 11621 11633 +12
===========================================
Hits 6639 6639
- Misses 4982 4994 +12
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fix boundary condition in test
Several issues have been addressed that were causing unexpected behaviour with EQE calculations. The new MJ example is much clearer. Performance of light-IV is improved. |
See issue #252.
Believe the problem is solved in the solve_bvp (default) method, but not in the Green's function method. This should happen before merging.
Edit: I believe the issue is now also solved in the Green's function method.
Other changes:
iv_depletion
to avoid looping over wavelengths (instead pass the wavelength-integrated generation*incident flux directly to the Green's function solver, similar to what already happens for the solve_bvp method). This makes the calculation for IV much faster.Due to how searchsorted works, this meant both
z1
andz2
were actually lower than z, which doesn't make sense and gives negative values forf
, and could in turn give negative values for the generation profile.