Build optimized operators lib with -fexceptions #7546

swolchok · 2025-01-07T18:07:34Z

Stack from ghstack (oldest at bottom):

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems.

TODO: presumably we need to manage rollout of the torchgen patch?

Differential Revision: D67904052

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

pytorch-bot · 2025-01-07T18:07:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

Failures because of deprecated version of actions/download-artifact: v3

❌ 9 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit b34b10d with merge base e1c0bcf ():

NEW FAILURES - The following jobs have failed:

docker-builds / docker-build (executorch-ubuntu-22.04-clang12-android) (gh)
Access to the path '/home/ec2-user/actions-runner/_work/_temp/_github_workflow/event.json' is denied.
docker-builds / docker-build (executorch-ubuntu-22.04-gcc9) (gh)
Access to the path '/home/ec2-user/actions-runner/_work/_temp/_github_workflow/event.json' is denied.
docker-builds / docker-build (executorch-ubuntu-22.04-linter) (gh)
Access to the path '/home/ec2-user/actions-runner/_work/_temp/_github_workflow/event.json' is denied.
Lint / android-java-format / linux-job (gh)
pull / test-binary-size-linux / linux-job (gh)
Access to the path '/home/ec2-user/actions-runner/_work/_temp/_github_workflow/event.json' is denied.
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe) / linux-job (gh)
Access to the path '/home/ec2-user/actions-runner/_work/_temp/_github_workflow/event.json' is denied.
trunk / test-arm-backend-delegation / linux-job (gh)
RuntimeError: Command docker exec -t af4350c17c160eac0c6b38c3a7ed636e9e51ed7e0b9a944b065e595d945be314 /exec failed with exit code 2
trunk / test-arm-reference-delegation / linux-job (gh)
RuntimeError: Command docker exec -t 687935e8289fe4d3fddbde229a0d2d69f0429653f2fb25c8866a82552d98a91a /exec failed with exit code 2
trunk / test-coreml-delegate / macos-job (gh)
/Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/runtime/include/executorch/runtime/core/portable_type/bfloat16.h:11:10: error: 'c10/util/BFloat16.h' file not found with <angled> include; use "quotes" instead

CANCELLED JOBS - The following jobs were cancelled. Please retry:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
##[error]The operation was canceled.
pull / test-llava-runner-linux / linux-job (gh)
##[error]The operation was canceled.

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh) (trunk failure)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-01-07T18:07:47Z

This pull request was exported from Phabricator. Differential Revision: D67904052

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

Pull Request resolved: #7546 It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? ghstack-source-id: 260556841 @exported-using-ghexport Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)

facebook-github-bot · 2025-01-07T22:21:27Z

This pull request was exported from Phabricator. Differential Revision: D67904052

swolchok · 2025-01-07T22:29:39Z

converting to draft to prevent accidental merge until the PR is updated to include a proper PyTorch pin bump; right now it points directly at pytorch/pytorch#144341 . It will still be reviewable whenever I get CI fixed

huydhn · 2025-01-08T02:04:24Z

build/Codegen.cmake


  message(STATUS "Generating operator lib:")
  message(STATUS "  LIB_NAME: ${GEN_LIB_NAME}")
  message(STATUS "  OPS_SCHEMA_YAML: ${GEN_OPS_SCHEMA_YAML}")
  message(STATUS "  ROOT_OPS: ${GEN_ROOT_OPS}")
  message(STATUS "  INCLUDE_ALL_OPS: ${GEN_INCLUDE_ALL_OPS}")
+  message(STATUS "  ADD_EXCEPTION_BOUNDARY: ${GEN_ADD_EXCEPTION_BOUNDARTY}")


Small typo

Suggested change

message(STATUS " ADD_EXCEPTION_BOUNDARY: ${GEN_ADD_EXCEPTION_BOUNDARTY}")

message(STATUS " ADD_EXCEPTION_BOUNDARY: ${GEN_ADD_EXCEPTION_BOUNDARY}")

huydhn · 2025-01-08T02:05:45Z

build/Codegen.cmake

-  )
+    )
+  if(GEN_ADD_EXCEPTION_BOUNDARY)
+    set(_gen_command "${_gen_command} --add-exception-boundary")


I think the set command use semi-colon separator instead of space, i.e. /opt/conda/envs/py_3.10/bin/python3;-m;torchgen.gen_executorch;--source-path=/pytorch/executorch/configurations/../codegen;--install-dir=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib;--tags-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/tags.yaml;--aten-yaml-path=/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torchgen/packaged/ATen/native/native_functions.yaml;--op-selection-yaml-path=/pytorch/executorch/pip-out/temp.linux-x86_64-cpython-310/cmake-out/configurations/optimized_native_cpu_ops_lib/selected_operators.yaml;--add-exception-boundary

The failure is complaining about a wrong filename https://github.com/pytorch/executorch/actions/runs/12660296601/job/35287265644#step:14:1992

Suggested change

set(_gen_command "${_gen_command} --add-exception-boundary")

set(_gen_command "${_gen_command}" --add-exception-boundary)

strange, I thought I built this locally. Giving it a shot now.

this does seem to have improved the situation (thanks!) but the torchgen version still seems to be wrong: https://github.com/pytorch/executorch/actions/runs/12680876952/job/35343491373?pr=7546#step:9:2186

@huydhn still seeing at least some wrong-torchgen-version failures:

test-arm-backend-delegation

test-arm-reference-delegation

test-llava-runner-linux

test-phi-3-mini-runner-linux

test-eval_llama-wikitext-linux

test-eval_llama-mmlu-linux

test-llama_runner_eager-linux

however, we do have mac successes. looking into the common thread for these failures now.

the ARM one is easy: the workflow directly invokes install_executorch from .ci/scripts/utils.sh without "use-pt-pinned-commit". Is there a reason "use-pt-pinned-commit" isn't the default or only option?

test-llava-runner-linux reruns install_requirements.sh and doesn't pass --use-pt-pinned-commit, same with test-phi-3-mini-runner, test-eval_llama-wikitext-linux, test-eval_llama-mmlu-linux, and test-llama_runner_eager-linux. I will send a PR to fix those.

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

facebook-github-bot · 2025-01-08T23:29:30Z

This pull request was exported from Phabricator. Differential Revision: D67904052

Pull Request resolved: #7546 It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? ghstack-source-id: 260686358 @exported-using-ghexport Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

Pull Request resolved: #7546 It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? ghstack-source-id: 260777714 @exported-using-ghexport Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)

facebook-github-bot · 2025-01-09T18:56:23Z

This pull request was exported from Phabricator. Differential Revision: D67904052

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

facebook-github-bot · 2025-01-09T22:35:47Z

This pull request was exported from Phabricator. Differential Revision: D67904052

Pull Request resolved: #7546 It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? ghstack-source-id: 260814512 @exported-using-ghexport Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546. Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/) [ghstack-poisoned]

It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/) [ghstack-poisoned]

facebook-github-bot · 2025-01-09T23:40:33Z

This pull request was exported from Phabricator. Differential Revision: D67904052

Pull Request resolved: #7546 It should be permissible for this library to use exceptions, since it is not required to supported embedded systems. TODO: presumably we need to manage rollout of the torchgen patch? ghstack-source-id: 260826290 @exported-using-ghexport Differential Revision: [D67904052](https://our.internmc.facebook.com/intern/diff/D67904052/)

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2025

swolchok mentioned this pull request Jan 7, 2025

Use c10 version of half/bfloat16 in executorch #7040

Open

swolchok mentioned this pull request Jan 6, 2025

Reuse GELU implementation from PyTorch core #7041

Open

facebook-github-bot added the fb-exported label Jan 7, 2025

swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 7, 2025

swolchok marked this pull request as draft January 7, 2025 22:28

huydhn reviewed Jan 8, 2025

View reviewed changes

kimishpatel approved these changes Jan 8, 2025

View reviewed changes

swolchok mentioned this pull request Jan 9, 2025

use-pt-pinned-commit for test-arm-{backend,reference}-delegation #7579

Open

swolchok mentioned this pull request Jan 9, 2025

stop double-installing ExecuTorch in one-off linux jobs #7578

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build optimized operators lib with -fexceptions #7546

Build optimized operators lib with -fexceptions #7546

swolchok commented Jan 7, 2025 •

edited

Loading

pytorch-bot bot commented Jan 7, 2025 •

edited

Loading

facebook-github-bot commented Jan 7, 2025

facebook-github-bot commented Jan 7, 2025

swolchok commented Jan 7, 2025

huydhn Jan 8, 2025 •

edited

Loading

huydhn Jan 8, 2025 •

edited

Loading

swolchok Jan 8, 2025

swolchok Jan 8, 2025

swolchok Jan 9, 2025 •

edited

Loading

swolchok Jan 9, 2025

facebook-github-bot commented Jan 8, 2025

facebook-github-bot commented Jan 9, 2025

facebook-github-bot commented Jan 9, 2025

facebook-github-bot commented Jan 9, 2025

	message(STATUS " ADD_EXCEPTION_BOUNDARY: ${GEN_ADD_EXCEPTION_BOUNDARTY}")
	message(STATUS " ADD_EXCEPTION_BOUNDARY: ${GEN_ADD_EXCEPTION_BOUNDARY}")

	set(_gen_command "${_gen_command} --add-exception-boundary")
	set(_gen_command "${_gen_command}" --add-exception-boundary)

Build optimized operators lib with -fexceptions #7546

Are you sure you want to change the base?

Build optimized operators lib with -fexceptions #7546

Conversation

swolchok commented Jan 7, 2025 • edited Loading

pytorch-bot bot commented Jan 7, 2025 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7546

❗ 1 Active SEVs

❌ 9 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

facebook-github-bot commented Jan 7, 2025

facebook-github-bot commented Jan 7, 2025

swolchok commented Jan 7, 2025

huydhn Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

huydhn Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

swolchok Jan 8, 2025

Choose a reason for hiding this comment

swolchok Jan 8, 2025

Choose a reason for hiding this comment

swolchok Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

swolchok Jan 9, 2025

Choose a reason for hiding this comment

facebook-github-bot commented Jan 8, 2025

facebook-github-bot commented Jan 9, 2025

facebook-github-bot commented Jan 9, 2025

facebook-github-bot commented Jan 9, 2025

swolchok commented Jan 7, 2025 •

edited

Loading

pytorch-bot bot commented Jan 7, 2025 •

edited

Loading

huydhn Jan 8, 2025 •

edited

Loading

huydhn Jan 8, 2025 •

edited

Loading

swolchok Jan 9, 2025 •

edited

Loading