Reuse GELU implementation from PyTorch core #7041

swolchok · 2024-11-23T00:01:08Z

Stack from ghstack (oldest at bottom):

kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.

Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.

Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.

Differential Revision: D66335522

kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch. Note that, because we will pick up Sleef internally and ignore it externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS. Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break. Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/) [ghstack-poisoned]

pytorch-bot · 2024-11-23T00:01:11Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 60 New Failures

As of commit 997b005 with merge base 7a2dc47 ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
RuntimeError: Command docker exec -t 483aaaac2f05ca64349855498ed1f7ebb8717c9b89705955854d1abb2c181003 /exec failed with exit code 1
Lint / lintrunner / linux-job (gh)
RuntimeError: Command docker exec -t 66823b941f96630b0acafeb61d78ce03eea345184b1f1dbbb05476eec591170c /exec failed with exit code 1
pull / test-custom-ops-linux / linux-job (gh)
RuntimeError: Command docker exec -t bbef3d3d4fd5a681fd135d1ed9a03ead661119898a8de117c1d2366b85a610d7 /exec failed with exit code 1
pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 887ab85c7a178f087eb39426e47d6697eea86d9d558fda222edafa55f5ec9ad0 /exec failed with exit code 1
pull / test-eval_llama-wikitext-linux / linux-job (gh)
RuntimeError: Command docker exec -t 4ed5410261d08e9c980a12f9fa10f3cafdcd80bb29efe5934645c31892f723bf /exec failed with exit code 1
pull / test-llama_runner_eager-linux / linux-job (gh)
RuntimeError: Command docker exec -t 952a9f754c67a377f7a83759290946eb4e645b02580bcd5b33fd6c3797636069 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, custom) / linux-job (gh)
RuntimeError: Command docker exec -t c5699bfd551e58a4a4f861602eea1abed4b5426ab79ef0e3e2c127cc1a5247a5 /exec failed with exit code 1
pull / test-llama-runner-linux (bf16, portable) / linux-job (gh)
RuntimeError: Command docker exec -t de35697ee5bcf87824d558e901ea31c195b4a127e3fac6eb034d04ed081a9667 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, portable) / linux-job (gh)
RuntimeError: Command docker exec -t 3bdb4dff862cedf54405630b7e0f92b415b4eb555e484591087819e5102c07f1 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom) / linux-job (gh)
RuntimeError: Command docker exec -t f70661bc8505860adfea6575e32fabefb4a0b957d43aa0459e8992142f0829f2 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+qe) / linux-job (gh)
RuntimeError: Command docker exec -t 220771d34e2ab277687f884adf5447139789f9278f8eaf6119faff0c216b4129 /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+custom+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t d62baa14984992533423928240bf6c5857b72c5181ce06538750dc660f30285f /exec failed with exit code 1
pull / test-llama-runner-linux (fp32, xnnpack+quantize_kv) / linux-job (gh)
RuntimeError: Command docker exec -t 3fc3d1ee23fbae209058da67969bd28f8484643c6d6861f4754006b6a532f563 /exec failed with exit code 1
pull / test-llama-runner-linux-android / linux-job (gh)
RuntimeError: Command docker exec -t 80434c45c2086cfcb9b9a30be248fc3335d67bb65e1b55a63bd15cce76218124 /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 15f276c405084fef83715a3bcf776bcb977ae9adb85e158623fa92a3d722f23c /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 22d22ff00042c1f236a4c8fa02a0b2f611a74f1a58fb83dcb6cce86acc432b4d /exec failed with exit code 1
pull / test-llava-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 99ffe382dae7f8a9db46eabbc951a970a2be551ab17fe441c7094d02399c0eba /exec failed with exit code 1
pull / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 550c71b7263b173fcb4fcf29be45c3fe47d54bf08598a4c8a0458d1cbfd3a41f /exec failed with exit code 1
pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t be8215633468bc929040dc0eaff267cce6d4b6e345c25716091a55966794f780 /exec failed with exit code 1
pull / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 56e2d124aadc5a996b8c1132fd763da9303bc13919fa3e5ff850bc93aefb23ad /exec failed with exit code 1
pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t 2293aa998c4e9df1d9ef4e4dd0c0084d70781d9797d736dbbbfc22723ee17404 /exec failed with exit code 1
pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t af3af314330fd27d6e282491b07bc59a3b1b85b8f3f13f958638fa10999b32f0 /exec failed with exit code 1
pull / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
RuntimeError: Command docker exec -t a15ef0db11a4b19f44e045b8bbba18f6232910b4f27f315746fce37494f4ab41 /exec failed with exit code 1
pull / test-phi-3-mini-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 4c8cd9d9549c8a664e193880be5fa0ede71a62c5f987815901b9b6c0bd45371a /exec failed with exit code 1
pull / test-pybind-build-linux / linux-job (gh)
RuntimeError: Command docker exec -t e37ae802ad02f0b5775a2538a51d2a5a73d440438d29aa31939360da153cc24a /exec failed with exit code 1
pull / test-quantized-aot-lib-linux / linux-job (gh)
RuntimeError: Command docker exec -t 47f7682b826012d02b8c27970d21410c9a5d9c7ab51c0078d56118a47a8f244e /exec failed with exit code 1
pull / test-selective-build-linux / linux-job (gh)
RuntimeError: Command docker exec -t 1aaba547c4bf8247cd04768ce14903bdecd208b545f2aa37ca68e3346e4ae9e5 /exec failed with exit code 1
pull / test-setup-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t d79e853fe0862111033196276cabc4365388b603d37f706c8257378b5ea2c21e /exec failed with exit code 1
pull / unittest / linux / linux-job (gh)
RuntimeError: Command docker exec -t eada2fc25bb907d34d56e5a35324a9f468ec2685e6aab0a057f573256700a2b4 /exec failed with exit code 1
pull / unittest / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
pull / unittest-arm / linux-job (gh)
RuntimeError: Command docker exec -t 915ffd147dee6bcc3bcff9a440584d298923cd26d472d7ecbaffc7202b466fd8 /exec failed with exit code 1
trunk / test-apple-model / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-arm-backend-delegation / linux-job (gh)
RuntimeError: Command docker exec -t 9786f2f9a67e9116477b30e16bf35152796cbe8cd51cc7040b45433b7b030761 /exec failed with exit code 1
trunk / test-arm-reference-delegation / linux-job (gh)
RuntimeError: Command docker exec -t 27aeaf8b30a77fa60b9916b147f87ddf8bdd918fd44e27ecc2761ee80f75903d /exec failed with exit code 1
trunk / test-coreml-delegate / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1
trunk / test-custom-ops-macos (cmake) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-demo-backend-delegation (buck2) / linux-job (gh)
RuntimeError: Command docker exec -t 24103478f28cca80959616a0b1296971bee92b356139a7bb8ed43f33365564df /exec failed with exit code 1
trunk / test-demo-backend-delegation (cmake) / linux-job (gh)
RuntimeError: Command docker exec -t bff0946c9eb87ac3dde08225933df33c8f124ed95b80110d5f2ae1bab6a5291e /exec failed with exit code 1
trunk / test-huggingface-transformers (google/gemma-2-2b) / linux-job (gh)
RuntimeError: Command docker exec -t 285290ebf44a7b11fb8b86787262cd61277e9e19263e8de8d376ddeef587a80a /exec failed with exit code 1
trunk / test-llama-runner-mac (bf16, custom) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (bf16, portable) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (fp32, coreml) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (fp32, mps) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (fp32, portable) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (fp32, xnnpack+custom+quantize_kv) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-mac (fp32, xnnpack+kv+custom) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 141af30603e7be933fdd8da51dbd4d470f041d2b2ce2e07bbf116657b4b02164 /exec failed with exit code 1
trunk / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 1889de5c690350827e67e68c80617a208ebcfe116147e9820e77f6f24f9b4bf3 /exec failed with exit code 1
trunk / test-models-macos (cmake, mv3, portable, macos-m1-stable, 90) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos (cmake, mv3, xnnpack-quantization-delegation, macos-m1-stable, 90) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos (cmake, vit, portable, macos-m1-stable, 90) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-models-macos (cmake, vit, xnnpack-quantization-delegation, macos-m1-stable, 90) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-pybind-build-macos (cmake) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
trunk / test-qnn-model (fp32, dl3) / linux-job (gh)
RuntimeError: Command docker exec -t 86c3c9d9478555272b8e3758c552fd6fb72f466518d1800f8f361c1b33f0faee /exec failed with exit code 1
trunk / test-qnn-model (fp32, ic3) / linux-job (gh)
RuntimeError: Command docker exec -t 24bbf43fdc78906cd18d234d992591c2a4a65d309deff751e786752ed8ee6d35 /exec failed with exit code 1
trunk / test-qnn-model (fp32, ic4) / linux-job (gh)
RuntimeError: Command docker exec -t cf948b89727119d4d6b1b084994dc5ee77162526c6275b2aaf33fc1a58d728e7 /exec failed with exit code 1
trunk / test-qnn-model (fp32, mv2) / linux-job (gh)
RuntimeError: Command docker exec -t 6c71b751bfce5c152027bdc5c1eab2949e004e7b0e1a59a9ad02014a206a6d28 /exec failed with exit code 1
trunk / test-qnn-model (fp32, mv3) / linux-job (gh)
RuntimeError: Command docker exec -t 74e94ef1f7006b3c63d8f74f0c459885d897f60db549d015b2d700f3337977b4 /exec failed with exit code 1
trunk / test-qnn-model (fp32, vit) / linux-job (gh)
RuntimeError: Command docker exec -t ee204a8b245ba5e8687efb88cc4b4995650197f4e1a9daaf7060aa2ff5b7313d /exec failed with exit code 1
trunk / test-selective-build-macos (cmake) / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-23T00:01:34Z