Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fix for output not being populated automatically #1339

Merged
merged 3 commits into from
Feb 23, 2024
Merged

add fix for output not being populated automatically #1339

merged 3 commits into from
Feb 23, 2024

Conversation

srmnitc
Copy link
Member

@srmnitc srmnitc commented Feb 23, 2024

Add fix to access output

@srmnitc srmnitc requested a review from jan-janssen February 23, 2024 10:49
@coveralls
Copy link

coveralls commented Feb 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8018331720

Details

  • 0 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.171%
Totals Coverage Status
Change from base Build 8015706973: 0.0%
Covered Lines: 14203
Relevant Lines: 15244
💛 - Coveralls

@srmnitc srmnitc requested a review from pmrv February 23, 2024 11:08
@srmnitc srmnitc added the format_black reformat the code using the black standard label Feb 23, 2024
@jan-janssen jan-janssen mentioned this pull request Feb 23, 2024
Open
pmrv
pmrv approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

pyiron/pyiron_base#1353 Will be good to have in general, but we can merge that separately.

@pmrv
Copy link
Contributor

pmrv commented Feb 23, 2024

lgtm.

pyiron/pyiron_base#1353 Will be good to have in general, but we can merge that separately.

I actually meant pyiron/pyiron_base#1352

@srmnitc srmnitc merged commit 2931bc1 into main Feb 23, 2024
25 checks passed
@srmnitc srmnitc deleted the fix_calphy_interface branch February 23, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

@jan-janssen jan-janssen Awaiting requested review from jan-janssen

Assignees
No one assigned
Labels
format_black reformat the code using the black standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srmnitc @coveralls @pmrv @jan-janssen @pyiron-runner