Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle refreshing the DataContainer for jobs submitted to the queuing system? #1353

Open
jan-janssen opened this issue Feb 23, 2024 · 1 comment
Assignees

Comments

@jan-janssen
Copy link
Member

@srmnitc brought up the issue that the data container is not reloaded when the job is submitted to the queuing system.

He introduced a fix in pyiron/pyiron_atomistics#1339

Still the general issues remains, while the job.status is updated by requesting the status from the database, this does not apply for other objects like the DataContainer attached to job.output. Previously this was not an issue as job.output was accessing the HDF5 file directly. Still now that the DataContainer is used for job.output it becomes more complicated.

@pmrv
Copy link
Contributor

pmrv commented Feb 23, 2024

I had toyed on Wednesday with a change that adds a callback to the JobStatus object. So when a GenericJob creates its JobStatus object, it would also add a callback to it that would call from_hdf when the job status becomes finished. A user could then in the notebook do job.refresh_status or just Project.wait_for_jobs and it would regenerate output objects once the job status is updated. I can create a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants