Bug/1279 metric checkin value is not validated correctly #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…n metric value field
…see if error message is shown
nevio18324
force-pushed
the
bug/1279-metric-checkin-value
branch
from
46157a6 to
f2d53cd
Compare
kcinay055679
requested changes
Jan 23, 2025
frontend/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form/check-in-form.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form/check-in-form.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form/check-in-form.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/components/checkin/check-in-form/check-in-form.component.ts
Outdated
Show resolved
Hide resolved
kcinay055679
requested changes
Jan 23, 2025
| @@ -28,11 +28,6 @@ export class CheckInFormMetricComponent implements OnInit { | |||
|
|
|||
There was a problem hiding this comment.
is hasFormFieldErrors still used?
| @@ -167,10 +177,10 @@ describe('CheckInFormComponent', () => { | |||
| component.keyResult = keyResultOrdinal; | |||
| component.ngOnInit(); | |||
| component.setDefaultValues(); | |||
| console.log(component.dialogForm.value); | |||
| ...baseCheckIn, | ||
| [this.keyResult.keyResultType === 'ordinal' ? 'zone' : 'value']: this.dialogForm.controls.value.value | ||
| }; | ||
| this.keyResult.keyResultType === 'metric' |
There was a problem hiding this comment.
that looks very weird improve readability
| @@ -178,4 +176,11 @@ export class CheckInFormComponent implements OnInit { | |||
| this.dialogForm.patchValue({ actionList: actionList }); | |||
| this.isAddingAction = false; | |||
| } | |||
|
|
|||
| setValidators(type: string) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.