Allow white spaces at start and end of number and write e2e tests to …

…see if error message is shown
puzzle · Jan 23, 2025 · f2d53cd · f2d53cd
1 parent 71d5cf3
commit f2d53cd
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/frontend/cypress/e2e/check-in.cy.ts b/frontend/cypress/e2e/check-in.cy.ts
@@ -44,6 +44,28 @@ describe('okr check-in', () => {
     cy.contains('- A new action on the action-plan');
   });
 
+  it('should show an error message when new check-in value is not numeric', () => {
+    overviewPage
+      .addKeyResult()
+      .fillKeyResultTitle('This key-result will have errors')
+      .withMetricValues(Unit.NUMBER, '21', '51')
+      .submit();
+
+    const detailPage = keyResultDetailPage
+      .visit('Very important keyresult')
+      .createCheckIn()
+      .fillMetricCheckInValue('asdf');
+    cy.contains('Neuer Wert muss eine Zahl sein.');
+
+    detailPage.fillMetricCheckInValue('21. 2');
+    cy.contains('Neuer Wert muss eine Zahl sein.');
+
+    detailPage.fillMetricCheckInValue('123');
+    cy.contains('Neuer Wert muss eine Zahl sein.')
+      .should('not.exist');
+  });
+
+
   it('should create check-in metric and assert correct owner', () => {
     overviewPage
       .addKeyResult()

diff --git a/...nd/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.spec.ts b/...nd/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.spec.ts
@@ -96,10 +96,14 @@ describe('CheckInFormComponent', () => {
       true],
     [-100.3,
       true],
-    ['123',
+    [' 123   ',
       true],
-    ['-123.4',
+    ['    -123.4   ',
       true],
+    ['12 .3',
+      false],
+    ['1 2',
+      false],
     ['',
       false],
     ['asdf',

diff --git a/frontend/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.ts b/frontend/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.ts
@@ -30,7 +30,7 @@ export class CheckInFormMetricComponent implements OnInit {
 
   ngOnInit() {
     this.dialogForm.controls['value'].setValidators([Validators.required,
-      Validators.pattern('^-?\\d+\\.?\\d*$')]);
+      Validators.pattern('^\\s*-?\\d+\\.?\\d*\\s*$')]);
   }
 
   generateUnitLabel(): string {