-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle typedef in zapt templates & matter_idl #36124
base: master
Are you sure you want to change the base?
Conversation
efaff8c
to
61d1605
Compare
@@ -24,10 +24,6 @@ | |||
"name": "cluster_header", | |||
"path": "../../../app/zap-templates/partials/cluster_header.zapt" | |||
}, | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somewhat unrelated & really more just cleanup: this file no longer exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs some test coverage to exercise these bits: please add something with typedefs to the UnitTesting cluster.
src/app/zap-templates/templates/app/cluster-typedefs-check.zapt
Outdated
Show resolved
Hide resolved
06f10b0
to
638b4bd
Compare
0bfb909
to
d8dbcb4
Compare
Dependent on zap updates at project-chip/zap#1458
Update zap templaets to process
typedef
in zap, supporting things like defining aVideoStreamID
as auint16
, see the camera spec: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10004This should also eliminate the need for many of the things in
chip-types.xml
, which can now be simply defined in the XML files as a simpletypedef
See also discussion with @bzbarsky-apple: #35773 (comment)
Testing
Verified by CI