Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup zap templates #37080

Merged
merged 5 commits into from
Jan 18, 2025
Merged

Cleanup zap templates #37080

merged 5 commits into from
Jan 18, 2025

Conversation

gmarcosb
Copy link
Contributor

@gmarcosb gmarcosb commented Jan 15, 2025 •
edited
Loading

This is a no-op change to prepare for #36124 which cleans things up & produces the same output

Testing

Verified by CI

@gmarcosb gmarcosb requested a review from a team as a code owner January 15, 2025 22:46
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 15, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/controller/java/templates/partials/decode_value.zapt Unsupported file format
  src/controller/java/templates/templates.json  0% smaller
  src/darwin/Framework/CHIP/templates/partials/decode_value.zapt Unsupported file format
  src/darwin/Framework/CHIP/templates/partials/encode_value.zapt Unsupported file format
  src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.mm Unsupported file format

bzbarsky-apple
bzbarsky-apple approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ZAP properly supports this now, so there is no change in output, great.

@github-actions GitHub Actions
Copy link

PR #37080: Size comparison from 11a6571 to e4b9bf4

Full report (3 builds for cc32xx, stm32)
platform target config section 11a6571 e4b9bf4 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540021 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574189 0 0.0
RAM 205432 205432 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484976 0 0.0
RAM 144752 144752 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

PR #37080: Size comparison from 7999db8 to fab4784

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 7999db8 fab4784 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840084 840084 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825600 825600 0 0.0
RAM 125424 125424 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772528 772528 0 0.0
RAM 113900 113900 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756724 756724 0 0.0
RAM 114100 114100 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540021 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574189 0 0.0
RAM 205432 205432 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917804 917804 0 0.0
RAM 143172 143172 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890868 890868 0 0.0
RAM 141359 141359 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851932 851932 0 0.0
RAM 142084 142084 0 0.0
qpg lighting-app qpg6105+debug FLASH 664144 664144 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 622004 622004 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484976 0 0.0
RAM 144752 144752 0 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1766984 1766984 0 0.0
RAM 93672 93672 0 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18218678 18218678 0 0.0
RAM 7959336 7959336 0 0.0

@github-actions GitHub Actions
Copy link

PR #37080: Size comparison from 7999db8 to 1e82c56

Full report (5 builds for cc32xx, stm32, tizen)
platform target config section 7999db8 1e82c56 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540021 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574189 0 0.0
RAM 205432 205432 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484976 0 0.0
RAM 144752 144752 0 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1766984 1766984 0 0.0
RAM 93672 93672 0 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18218678 18218678 0 0.0
RAM 7959336 7959336 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR #37080: Size comparison from 92c88e4 to b8b8d47

Full report (3 builds for cc32xx, stm32)
platform target config section 92c88e4 b8b8d47 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540021 540021 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574189 574189 0 0.0
RAM 205432 205432 0 0.0
stm32 light STM32WB5MM-DK FLASH 484976 484976 0 0.0
RAM 144752 144752 0 0.0

@github-actions GitHub Actions
Copy link

PR #37080: Size comparison from 5055cbe to a87ecd7

Full report (3 builds for cc32xx, stm32)
platform target config section 5055cbe a87ecd7 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539693 539693 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 573789 573789 0 0.0
RAM 205432 205432 0 0.0
stm32 light STM32WB5MM-DK FLASH 484448 484448 0 0.0
RAM 144752 144752 0 0.0

@gmarcosb
Copy link
Contributor Author

FYI, had to include a generated file because the whitespace did change (for the better, though still not great)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

PR #37080: Size comparison from c389092 to 790c7b6

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c389092 790c7b6 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092720 1092720 0 0.0
RAM 103362 103362 0 0.0
bl702 lighting-app bl702+eth FLASH 650714 650714 0 0.0
RAM 25365 25365 0 0.0
bl702+wifi FLASH 828638 828638 0 0.0
RAM 14105 14105 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055924 1055924 0 0.0
RAM 23957 23957 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888894 888894 0 0.0
RAM 18636 18636 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971908 971908 0 0.0
RAM 16484 16484 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838204 838204 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823648 823648 0 0.0
RAM 125416 125416 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770840 770840 0 0.0
RAM 113908 113908 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755108 755108 0 0.0
RAM 114108 114108 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538621 538621 0 0.0
RAM 205296 205296 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572477 572477 0 0.0
RAM 205432 205432 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679633 679633 0 0.0
RAM 78604 78604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699477 699477 0 0.0
RAM 81244 81244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699477 699477 0 0.0
RAM 81244 81244 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656421 656421 0 0.0
RAM 73672 73672 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616033 616033 0 0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635669 635669 0 0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635669 635669 0 0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635513 635513 0 0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655229 655229 0 0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655229 655229 0 0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612005 612005 0 0.0
RAM 68692 68692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631865 631865 0 0.0
RAM 71324 71324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631865 631865 0 0.0
RAM 71324 71324 0 0.0
efr32 lock-app BRD4187C FLASH 934728 934728 0 0.0
RAM 160004 160004 0 0.0
BRD4338a FLASH 730420 730412 -8 -0.0
RAM 234844 234844 0 0.0
window-app BRD4187C FLASH 1030136 1030136 0 0.0
RAM 128112 128112 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1537254 1537254 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1544806 1544806 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2709891 2709891 0 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5975152 5975152 0 0.0
RAM 531880 531880 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5323196 5323196 0 0.0
RAM 242992 242992 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4682176 4682176 0 0.0
RAM 221744 221744 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13045286 13045286 0 0.0
RAM 596634 596634 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11125792 11125792 0 0.0
RAM 648168 648168 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11392261 11392261 0 0.0
RAM 596978 596978 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507350 4507350 0 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5610149 5610149 0 0.0
RAM 483656 483656 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5617313 5617313 0 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4732060 4732060 0 0.0
RAM 207976 207976 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4361050 4361050 0 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4498588 4498588 0 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3005533 3005533 0 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9568 9568 0 0.0
FLASH 4102152 4102152 0 0.0
RAM 246224 246224 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5949653 5949653 0 0.0
RAM 607088 607088 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11272733 11272733 0 0.0
RAM 711064 711064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913884 913884 0 0.0
RAM 143176 143176 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 889048 889048 0 0.0
RAM 141363 141363 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848664 848664 0 0.0
RAM 142088 142088 0 0.0
nxp contact k32w0+release FLASH 584424 584424 0 0.0
RAM 70960 70960 0 0.0
mcxw71+release FLASH 599832 599832 0 0.0
RAM 63176 63176 0 0.0
light k32w0+release FLASH 610884 610884 0 0.0
RAM 70352 70352 0 0.0
k32w1+release FLASH 685416 685416 0 0.0
RAM 48768 48768 0 0.0
lock mcxw71+release FLASH 761480 761480 0 0.0
RAM 70788 70788 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647004 1647004 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553604 1553604 0 0.0
RAM 208448 208448 0 0.0
light cy8ckit_062s2_43012 FLASH 1469644 1469644 0 0.0
RAM 200416 200416 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467596 1467596 0 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 662144 662144 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 619924 619924 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 482784 482784 0 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 681828 681828 0 0.0
RAM 91092 91092 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 622000 622000 0 0.0
RAM 31492 31492 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770836 770836 0 0.0
RAM 49352 49352 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 775278 775278 0 0.0
RAM 99656 99656 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709216 709216 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626224 626224 0 0.0
RAM 142024 142024 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812288 812288 0 0.0
RAM 99568 99568 0 0.0
tizen all-clusters-app arm unknown 5132 5132 0 0.0
FLASH 1754928 1754928 0 0.0
RAM 93680 93680 0 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18216942 18216942 0 0.0
RAM 7958632 7958632 0 0.0

@mergify mergify bot merged commit 9e23d47 into project-chip:master Jan 18, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
controller darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmarcosb @andy31415 @bzbarsky-apple