Rename function to closely match spec #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GleasonK
approved these changes
Feb 5, 2024
GleasonK
requested changes
Feb 5, 2024
GleasonK
approved these changes
Feb 6, 2024
mlevesquedion
pushed a commit
to mlevesquedion/stablehlo
that referenced
this pull request
Feb 7, 2024
This seems to be from openxla#1987. Not sure how presubmit failed to catch this.
mlevesquedion
pushed a commit
that referenced
this pull request
Feb 7, 2024
This seems to be from #1987 (see https://github.com/openxla/stablehlo/actions/runs/7808382192/job/21298492956). Not sure how presubmit failed to catch this. I think what happened is the following: 1. #1987 was uploaded and passed presubmit. 2. #1983 was submitted, adding a new use of `makeScalar`. 3. #1987 was submitted, deleting `makeScalar` and causing tests to fail at HEAD. What I don't understand is why this sequence of operations is possible in the first place. I feel like when #1983 was submitted, the earlier passing presubmit on #1987 should have been invalidated, blocking submit. I guess presubmits only re-run if you add a commit? So in this case since there was no new commit and no conflict, no new commit needed to be pushed and the presubmits were not run again. In the grand scheme of things, I think this is fairly minor, but we may want to investigate whether we can prevent this somehow by tweaking some configuration settings or something.
ghpvnist
added a commit
that referenced
this pull request
Feb 8, 2024
With the recent change to rename a function to match spec in #1987, I noticed that several ops also rely on this meta function that can also benefit from name change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, looking at the spec of
collective_broadcast, we come across the statement:broadcast_in_dim(constant(0, element_type(result)), [], type(result))otherwise.This PR renames
makeScalar()toconstant()with arguments matching the spec above for parity.