Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new constant function instead of deleted makeScalar function #1996

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

mlevesquedion
Copy link
Contributor

@mlevesquedion mlevesquedion commented Feb 7, 2024

This seems to be from #1987 (see https://github.com/openxla/stablehlo/actions/runs/7808382192/job/21298492956).

Not sure how presubmit failed to catch this. I think what happened is the following:

  1. Rename function to closely match spec #1987 was uploaded and passed presubmit.
  2. Add interpreter for CollectiveBroadcastOp #1983 was submitted, adding a new use of makeScalar.
  3. Rename function to closely match spec #1987 was submitted, deleting makeScalar and causing tests to fail at HEAD.

What I don't understand is why this sequence of operations is possible in the first place. I feel like when #1983 was submitted, the earlier passing presubmit on #1987 should have been invalidated, blocking submit. I guess presubmits only re-run if you add a commit? So in this case since there was no new commit and no conflict, no new commit needed to be pushed and the presubmits were not run again.

In the grand scheme of things, I think this is fairly minor, but we may want to investigate whether we can prevent this somehow by tweaking some configuration settings or something.

This seems to be from openxla#1987. Not sure how presubmit failed to catch this.
Copy link
Member

@ghpvnist ghpvnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting edge case, I agree preventing this could be useful but likely to be rare (this is the first time encountering this as far as I remember). Thanks for fixing this!

@ghpvnist ghpvnist assigned mlevesquedion and unassigned ghpvnist Feb 7, 2024
@mlevesquedion mlevesquedion merged commit 5f9f07b into openxla:main Feb 7, 2024
10 checks passed
@mlevesquedion mlevesquedion deleted the fix-missed-make-scalar branch February 7, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants