Use new constant function instead of deleted makeScalar function #1996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be from #1987 (see https://github.com/openxla/stablehlo/actions/runs/7808382192/job/21298492956).
Not sure how presubmit failed to catch this. I think what happened is the following:
makeScalar
.makeScalar
and causing tests to fail at HEAD.What I don't understand is why this sequence of operations is possible in the first place. I feel like when #1983 was submitted, the earlier passing presubmit on #1987 should have been invalidated, blocking submit. I guess presubmits only re-run if you add a commit? So in this case since there was no new commit and no conflict, no new commit needed to be pushed and the presubmits were not run again.
In the grand scheme of things, I think this is fairly minor, but we may want to investigate whether we can prevent this somehow by tweaking some configuration settings or something.