Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2 bugfixes (brand not removable + minor issue) #6199

Merged
merged 2 commits into from
Jan 13, 2025
+6 −4
Merged

fix: 2 bugfixes (brand not removable + minor issue) #6199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7307d46
Always unfocus before showing the "May exit…" sheet
g123k Jan 13, 2025
bb8b7d5
Fix: unable to remove reordered brands
g123k Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/smooth_app/lib/pages/product/add_basic_details_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class _AddBasicDetailsPageState extends State<AddBasicDetailsPage> {
final SimpleInputPageBrandsHelper _brandsHelper =
SimpleInputPageBrandsHelper();
late final MultilingualHelper _multilingualHelper;
late final FocusNode _focusNode;

/// Only used when there's not enough place
bool _showPhotosBanner = false;
Expand All @@ -81,7 +80,6 @@ class _AddBasicDetailsPageState extends State<AddBasicDetailsPage> {
monolingualText: _product.productName,
productLanguage: _product.lang,
);
_focusNode = FocusNode();
}

@override
Expand Down Expand Up @@ -137,7 +135,6 @@ class _AddBasicDetailsPageState extends State<AddBasicDetailsPage> {
_productNameController.dispose();
_brandsController.dispose();
_weightController.dispose();
_focusNode.dispose();
super.dispose();
}

Expand Down
5 changes: 5 additions & 0 deletions packages/smooth_app/lib/pages/product/may_exit_page_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,12 @@ class MayExitPageHelper {
Future<bool?> openSaveBeforeLeavingDialog(
final BuildContext context, {
final String? title,
final bool unfocus = true,
}) async {
if (unfocus) {
FocusManager.instance.primaryFocus?.unfocus();
}

final AppLocalizations appLocalizations = AppLocalizations.of(context);
final SmoothColorsThemeExtension extension =
context.extension<SmoothColorsThemeExtension>();
Expand Down
2 changes: 1 addition & 1 deletion packages/smooth_app/lib/pages/product/simple_input_page_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ abstract class AbstractSimpleInputPageHelper extends ChangeNotifier {

/// Mainly used when reordering the list.
void replaceItems(final List<String> items) {
_terms = items;
_terms = List<String>.of(items);
_changed = true;
notifyListeners();
}
Expand Down
Loading