Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2 bugfixes (brand not removable + minor issue) #6199

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 13, 2025

Hi everyone!

This PR fixes two issues:

  • With the list of brands, it was impossible to delete a reordered brand
  • The popup "Quit without saving?" ensures the current textfield is unfocused

@github-actions github-actions bot added 🥫 Product page ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Basic info input labels Jan 13, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.23%. Comparing base (4d9c7fc) to head (bb8b7d5).
Report is 654 commits behind head on develop.

Files with missing lines Patch % Lines
...th_app/lib/pages/product/may_exit_page_helper.dart 0.00% 1 Missing ⚠️
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6199      +/-   ##
==========================================
- Coverage     9.54%   6.23%   -3.32%     
==========================================
  Files          325     456     +131     
  Lines        16411   26578   +10167     
==========================================
+ Hits          1567    1656      +89     
- Misses       14844   24922   +10078     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit d488eeb into openfoodfacts:develop Jan 13, 2025
6 checks passed
@g123k g123k deleted the bugfixes_1305 branch January 13, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Basic info input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🥫 Product page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants