Lk/learning language selection #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update tests so we have less error message test: update test
leangseu-edx
force-pushed
the
lk/learning-language-selection
branch
from
5fb172d to
714b7af
Compare
leangseu-edx
requested review from
jansenk,
BrandonHBodine,
Rodra,
nsprenkle and
hajorg
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/whole-course-translations #1299 +/- ##
==================================================================
+ Coverage 88.36% 88.49% +0.12%
==================================================================
Files 291 297 +6
Lines 4941 5005 +64
Branches 1245 1258 +13
==================================================================
+ Hits 4366 4429 +63
- Misses 561 562 +1
Partials 14 14 ☔ View full report in Codecov by Sentry. |
leangseu-edx
changed the base branch from
master
to
feat/whole-course-translations
BrandonHBodine
approved these changes
Feb 26, 2024
nsprenkle
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Just tested with the https://github.com/openedx/edx-platform/tree/feat/whole-course-translations branch and it works 
This was referenced Mar 13, 2024
leangseu-edx
added a commit
that referenced
this pull request
Mar 20, 2024
* feat: add language selection chore: update tests so we have less error message test: update test * test: update tests * chore: remove duplicate translation * chore: lint for console * chore: remove comments * chore: make sure the affect url frame refresh after the language selection change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
npx jest {path} -u. This make writing test so much faster.jest-console-group-reporterto group logs. With it, I was able to kick out a few of the unnecessary console like missing props etc. There are still a lot more.language-selection.mov