Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lk/add translation src dest #1314

Merged

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Mar 4, 2024

  • chore: add src and dest translation

@leangseu-edx leangseu-edx changed the base branch from master to feat/whole-course-translations March 4, 2024 15:43
@leangseu-edx leangseu-edx marked this pull request as ready for review March 5, 2024 15:15
Copy link
Contributor

@nsprenkle nsprenkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one open question.

@@ -110,8 +110,6 @@ function normalizeMetadata(metadata) {
showCalculator: data.show_calculator,
notes: camelCaseObject(data.notes),
marketingUrl: data.marketing_url,
language: data.language,
wholeCourseTranslationEnabled: data.whole_course_translation_enabled,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you still want this "enabled" field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This place was incorrect. I realize that after connect it to the backend.

@leangseu-edx leangseu-edx merged commit 69aa9a3 into feat/whole-course-translations Mar 6, 2024
1 check passed
@leangseu-edx leangseu-edx deleted the lk/add-translation-src-dest branch March 6, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants