Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stomatogastric ganglion cell types of crabs, lobsters #2876

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

stevevanhooser
Copy link

With @andreagaede, added 8 cell types from the stomatogastric ganglion of crabs and lobsters (thought to be homologous neurons).

It references a relatively new UBERON node: UBERON:8910001 ! stomatogastric ganglion

It views well in Protoge

@stevevanhooser
Copy link
Author

Not sure which reviewer to request (apparently I cannot suggest one), but we discussed these changes with @gouttegd and @rays22 at the November meeting.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the inline comments below. I only commented on the first new term, but the comments apply, mutatis mutandis, to all the proposed new terms.

It is especially important to fix the incorrect use of EquivalentClasses and of the in taxon relationship.

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@stevevanhooser
Copy link
Author

Fixes made, looks good to me in Protege, this note from @gouttegd remains relevant:

Side note (more intended for other reviewers): UBERON:8910001 has only been added to Uberon last month, and there has been no new Uberon release since then. We will need to wait for a Uberon release and then refresh the imports.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your reactivity, much appreciated!

Out of the following comments, the critical one is the one about the duplicated definitions of CL:4070014 and CL:4070017.

With the other comments, we are entering into “nitpicking“ territory, which is good as it means that the most important issues have been addressed.

src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
src/ontology/cl-edit.owl Show resolved Hide resolved
@stevevanhooser
Copy link
Author

Thanks also for your quick responses. Updated

src/ontology/cl-edit.owl Show resolved Hide resolved
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

As previously noted though, we’ll need to wait for UBERON:8910001 to become available in the next Uberon release.

@stevevanhooser
Copy link
Author

Thanks for your help @gouttegd!

Are these releases at regular intervals or just as the developers are ready?

Thanks again
Steve

@gouttegd
Copy link
Collaborator

gouttegd commented Jan 8, 2025

We try to make one release every 6 to 8 weeks. The last Uberon release was in late November, so I’d expect the next one to happen before the end of the month. No promises, though.

@aleixpuigb
Copy link
Collaborator

This looks good to me.

As previously noted though, we’ll need to wait for UBERON:8910001 to become available in the next Uberon release.

I can run an Uberon release soon (early next week to give enough time to close PRs). I will make the announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants