Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServerInitiatedDirectiveRecevierStateDidChange가 정확하게 내려오지 않던 문제 수정 #1155

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jayce1116
Copy link
Collaborator

Description

  • ServerInitiatedDirectiveRecevierStateDidChange가 정확하게 내려오지 않던 문제 수정
  • startReceiveServerInitiatedDirective, stopReceiveServerInitiatedDirective 를 호출할 때 unconnected 혹은 disconnected 보다 serverInitiatedDirectiveStateDisposable 이 우선적으로 dispose 되고 있어서 state를 정상적으로 수신할 수 없고, NuguClient의 delegate 메서드에서 unconnected, disconnected를 수신할 수 없었음.

@jayce1116 jayce1116 added the bug Something isn't working label Apr 23, 2024
@jayce1116 jayce1116 requested a review from childc as a code owner April 23, 2024 07:53
@jayce1116 jayce1116 self-assigned this Apr 23, 2024
@jayce1116 jayce1116 merged commit 47bfc3e into nugu-developers:develop/1.10.1 Apr 23, 2024
1 check passed
@jayce1116 jayce1116 deleted the improve/directive-receive-state branch April 23, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant