Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link tokens to theme builder #894

Merged
merged 7 commits into from
Jan 15, 2025
Merged

feat: add link tokens to theme builder #894

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4dce9b
feat: add link tokens to theme builder
Dec 27, 2024
859a5a9
feat: add placeholder link tokens
Dec 27, 2024
e3784b7
feat: add classname to link placeholder
Dec 27, 2024
3ec742b
refactor: rename link token
Dec 30, 2024
668382d
refactor: removed classname
Dec 30, 2024
c1dc8a2
fix: simulate `focus` and `focus-visible` state at the same time
Robbert Jan 14, 2025
504934f
Apply suggestions from code review
Robbert Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions packages/theme-toolkit/src/component-stories-utrecht.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,7 +2026,26 @@ export const UTRECHT_COMPONENT_STORIES: ComponentStory[] = [
</Link>
),
detectTokens: {
anyOf: ['utrecht.link.color', 'utrecht.link.text-decoration', 'utrecht.link.text-decoration-thickness'],
anyOf: [
'utrecht.link.color',
'utrecht.link.text-decoration',
'utrecht.link.text-decoration-thickness',
'utrecht.link.text-underline-offset',
],
},
},
{
storyId: 'react-utrecht-link--active',
group: STORY_GROUPS['LINK'],
name: 'Utrecht Link: Active',
inline: true,
render: () => (
<Link href="https://example.com" target="_new" external className="utrecht-link--active">
The Quick Brown Fox Jumps Over The Lazy Dog
</Link>
),
detectTokens: {
anyOf: ['utrecht.link.active.color'],
},
},
{
Expand All @@ -2048,6 +2067,21 @@ export const UTRECHT_COMPONENT_STORIES: ComponentStory[] = [
],
},
},
{
storyId: 'react-utrecht-link--placeholder',
group: STORY_GROUPS['LINK'],
name: 'Utrecht Link: Placeholder',
state: true,
inline: true,
render: () => (
<Link href="https://example.com" target="_new" placeholder>
The Quick Brown Fox Jumps Over The Lazy Dog
</Link>
),
detectTokens: {
anyOf: ['utrecht.link.placeholder.color', 'utrecht.link.placeholder.font-weight'],
},
},
{
storyId: 'react-utrecht-link--focus',
group: STORY_GROUPS['LINK'],
Expand All @@ -2062,6 +2096,7 @@ export const UTRECHT_COMPONENT_STORIES: ComponentStory[] = [
detectTokens: {
anyOf: [
'utrecht.link.focus.color',
'utrecht.link.focus.background-color',
'utrecht.link.focus.text-decoration',
'utrecht.link.focus.text-decoration-thickness',
],
Expand All @@ -2074,10 +2109,18 @@ export const UTRECHT_COMPONENT_STORIES: ComponentStory[] = [
state: true,
inline: true,
render: () => (
<Link href="https://example.com" target="_new" external className="utrecht-link--focus-visible">
<Link
href="https://example.com"
target="_new"
external
className="utrecht-link--focus utrecht-link--focus-visible"
>
The Quick Brown Fox Jumps Over The Lazy Dog
</Link>
),
detectTokens: {
anyOf: ['utrecht.link.focus-visible.text-decoration', 'utrecht.link.focus-visible.text-decoration-thickness'],
},
},
{
storyId: 'react-utrecht-link--visited',
Expand All @@ -2090,6 +2133,9 @@ export const UTRECHT_COMPONENT_STORIES: ComponentStory[] = [
The Quick Brown Fox Jumps Over The Lazy Dog
</Link>
),
detectTokens: {
anyOf: ['utrecht.link.visited.color'],
},
},
{
storyId: 'react-utrecht-document--default',
Expand Down
Loading