generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add link tokens to theme builder #894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 89.57% 89.72% +0.15%
==========================================
Files 19 19
Lines 1343 1363 +20
Branches 167 181 +14
==========================================
+ Hits 1203 1223 +20
Misses 140 140 ☔ View full report in Codecov by Sentry. |
Robbert
reviewed
Dec 30, 2024
Marwaxhello
force-pushed
the
feat/component-story-tokens-link
branch
from
January 9, 2025 12:52
3a2bdbf
to
668382d
Compare
Robbert
reviewed
Jan 14, 2025
Robbert
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
In deze pull request heb ik link tokens toegevoegd aan de theme-builder:
link-default
link-focus
link-focus-visible
link-hover
link-placeholder
link-active
link-visited
link-icon
Hoe weet ik welke tokens ik moet gebruiken voor elke link-variant? Mijn bron is het Storybook van Gemeente Utrecht, waar je onderaan de pagina alle gebruikte en bestaande tokens voor een specifieke component en de verschillende staten van die component kunt vinden.