Only close the cache db if it is not null. #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
This fixes a bug where the cache db is not closed if an exception occurs when opening it. This unhandled exception will cause Nextflow to fail and prevent the Global.cleanUp() from being called. Signed-off-by: Rob Syme <[email protected]>
robsyme
force-pushed
the
safe-cache-db-close
branch
from
9ad390b to
c5e5fa4
Compare
Signed-off-by: Rob Syme <[email protected]>
robsyme
force-pushed
the
safe-cache-db-close
branch
from
7d8ca2f to
4b487ff
Compare
pditommaso
reviewed
Jan 3, 2025
pditommaso
reviewed
Jan 3, 2025
Signed-off-by: Rob Syme <[email protected]>
robsyme
force-pushed
the
safe-cache-db-close
branch
from
8003dfb to
7e0b896
Compare
pditommaso
reviewed
Jan 3, 2025
Signed-off-by: Rob Syme <[email protected]>
robsyme
force-pushed
the
safe-cache-db-close
branch
from
22bfb45 to
df8b387
Compare
|
There is a failing docs snippet, likely due to an environment mismatch. I will update that test in a separate PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the cache db is not closed if an exception occurs when opening it. This unhandled exception will cause Nextflow to fail and prevent the Global.cleanUp() from being called.