Use try-with-resources to close CacheDB.

nextflow-io · Jan 3, 2025 · 8003dfb · 8003dfb
1 parent 4b487ff
commit 8003dfb
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/modules/nextflow/src/main/groovy/nextflow/Session.groovy b/modules/nextflow/src/main/groovy/nextflow/Session.groovy
@@ -1209,10 +1209,8 @@ class Session implements ISession {
         if( aborted || cancelled || error )
             return
 
-        CacheDB db = null
-        try {
+        try (CacheDB db = CacheFactory.create(uniqueId, runName).openForRead()) {
             log.trace "Cleaning-up workdir"
-            db = CacheFactory.create(uniqueId, runName).openForRead()
             db.eachRecord { HashCode hash, TraceRecord record ->
                 def deleted = db.removeTaskEntry(hash)
                 if( deleted ) {
@@ -1223,10 +1221,7 @@ class Session implements ISession {
             log.trace "Clean workdir complete"
         }
         catch( Exception e ) {
-            log.warn("Failed to cleanup work dir: ${workDir.toUriString()}. Exception: ${e.message}")
-        }
-        finally {
-            db?.close()
+            log.warn("Failed to cleanup work dir: ${workDir.toUriString()}", e)
         }
     }