Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): changing legend_enabled/legend field to pointer type #2737

Closed
wants to merge 2 commits into from
Closed

fix(dashboard): changing legend_enabled/legend field to pointer type #2737

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e887b4
fix(dashboard): changing legend_enabled/legend field to pointer type
vinay-newrelic Aug 26, 2024
cd682f2
Merge branch 'main' into NR-306313
shashank-reddy-nr Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion newrelic/structures_newrelic_one_dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,8 @@

if q, ok := w["legend_enabled"]; ok {
var l dashboards.DashboardWidgetLegend
l.Enabled = q.(bool)
qBool, _ := q.(bool)
l.Enabled = &qBool

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / test-unit 

cannot use &qBool (value of type *bool) as bool value in assignment

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / test-unit 

cannot use &qBool (value of type *bool) as bool value in assignment

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / test-integration 

cannot use &qBool (value of type *bool) as bool value in assignment

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / test-integration 

cannot use &qBool (value of type *bool) as bool value in assignment

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / compile (1.21.x, ubuntu-latest) 

cannot use &qBool (value of type *bool) as bool value in assignment

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use &qBool (value of type *bool) as bool value in assignment) (typecheck)

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / lint 

cannot use &qBool (value of type *bool) as bool value in assignment (typecheck)

Check failure on line 623 in newrelic/structures_newrelic_one_dashboard.go

View workflow job for this annotation

GitHub Actions / compile (1.21.x, macos-latest) 

cannot use &qBool (value of type *bool) as bool value in assignment
cfg.Legend = &l
}
if q, ok := w["facet_show_other_series"]; ok {
Expand Down
Loading