Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): changing legend_enabled/legend field to pointer type #2737

Closed
wants to merge 2 commits into from

Conversation

vinay-newrelic
Copy link
Contributor

@vinay-newrelic vinay-newrelic commented Aug 26, 2024

⚠️ DO NOT MERGE

Description

Currently, if user send the value for legend_enabled as false while creating dashboards, that is currently being ignored, and the default value of true is being used. Fixed it by changing the boolean field to a pointer.

Fixes #2736

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

Copy link
Contributor

@shashank-reddy-nr shashank-reddy-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this and correct this if required.
Screenshot 2024-08-28 at 2 00 42 PM

@shashank-reddy-nr
Copy link
Contributor

shashank-reddy-nr commented Aug 28, 2024

Please link these terraform changes to client-go locally and try to run/test all dashboard related integration tests locally and make sure nothing new test cases are breaking

@vinay-newrelic
Copy link
Contributor Author

i have ran all the test cases and hence no error has been found . So we are good with changes as of now and no changes is needed as per the pic.

@pranav-new-relic
Copy link
Member

Thanks for the review @shashank-reddy-nr.

@vinay-newrelic please change the reference of newrelic-client-go in go.mod, go.sum in this PR (temporarily) so all CI checks (compile, tests etc.) are no longer obstructed and run successfully. This is a general practice we follow to make sure all integration tests pass with the required changes in the Go Client. Once the changes in the Go Client are released, we can then point the newrelic-client-go version reference to the released version of the Go Client, after which the PR may be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource newrelic_one_dashboard: Unable to disable legend in widget_line
3 participants