Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make pipeline-catalog submodule available to built Docker image #373

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Nov 4, 2024

Changes proposed in this PR:

  • Fixes our GH actions workflows for building + pushing images to DockerHub to check out submodules

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

- CLI functionality now depends on a submodule (pipeline-catalog)
@alyssadai alyssadai added release Create a release when this PR is merged pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) labels Nov 4, 2024
@alyssadai alyssadai requested a review from surchs November 4, 2024 21:25
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (282cc7d) to head (8676d0c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #373   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          16       16           
  Lines         983      983           
=======================================
  Hits          967      967           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link
Collaborator

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11676619270

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.372%

Totals Coverage Status
Change from base Build 11672898473: 0.0%
Covered Lines: 967
Relevant Lines: 983

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good, just a 🍒 note on inflated image size

🧑‍🍳

.github/workflows/build_docker_nightly.yml Show resolved Hide resolved
@alyssadai
Copy link
Contributor Author

Hey Seb, re-requesting your review here for an extra pair of eyes on the Dockerfile changes.

Agree with your suggestion to only copy in required files. As part of maybe #350, I think we can also move the test suite out of the bagel directory for the same reason, since we don't need to copy the tests into the image (and it's best practice to keep them separate from the main program code, like how we're doing in the API repos).

@alyssadai alyssadai requested a review from surchs November 4, 2024 22:06
Dockerfile Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit e08abb3 into main Nov 5, 2024
11 checks passed
@alyssadai alyssadai deleted the fix-docker-wfs branch November 5, 2024 02:52
Copy link
Contributor

neurobagel-bot bot commented Nov 5, 2024

🚀 PR was released in v0.3.2 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unrecognized pipelines when adding imaging derivatives
3 participants