-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Make pipeline-catalog
submodule available to built Docker image
#373
Conversation
- CLI functionality now depends on a submodule (pipeline-catalog)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 16 16
Lines 983 983
=======================================
Hits 967 967
Misses 16 16 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11676619270Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good, just a 🍒 note on inflated image size
🧑🍳
Hey Seb, re-requesting your review here for an extra pair of eyes on the Dockerfile changes. Agree with your suggestion to only copy in required files. As part of maybe #350, I think we can also move the test suite out of the |
🚀 PR was released in |
Changes proposed in this PR:
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: