Skip to content

Commit

Permalink
[FIX] Make pipeline-catalog submodule available to built Docker ima…
Browse files Browse the repository at this point in the history
…ge (#373)

* check out submodules before building Docker image
- CLI functionality now depends on a submodule (pipeline-catalog)

* expand ignore patterns in .dockerignore
- only copy required files into Docker image
  • Loading branch information
alyssadai authored Nov 5, 2024
1 parent c216b24 commit e08abb3
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 4 deletions.
19 changes: 15 additions & 4 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,31 @@ bagelbids.egg-info
.eggs/**/*
.eggs

.editorconfig
**/.git
**/.github
**/.gitignore
**/.vscode
**/coverage
**/.env
**/.aws
**/.ssh
Dockerfile
README.md
docker-compose.yml
**/.DS_Store
**/venv
**/env
Dockerfile

bids-examples
# other configuration files and scripts
.autorc
.pre-commit-config.yaml
generate_nb_vocab_file.py

# documentation
CHANGELOG.md
CITATION.cff
LICENSE
README.md

# submodules used for testing
bids-examples
neurobagel_examples
2 changes: 2 additions & 0 deletions .github/workflows/build_docker_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive

- name: Login to Docker Hub
uses: docker/login-action@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_docker_on_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
-
name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive
-
# The release event is a superset of the push tag event,
# so we expect two tags to be generated by docker/metadata-action
Expand Down
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ FROM python:3.10-slim-buster

WORKDIR /app
COPY . /app/src

# To have a deterministic build, we
# 1. install the environment from our lockfile
RUN pip install -r /app/src/requirements.txt
Expand Down

0 comments on commit e08abb3

Please sign in to comment.