added Language dropdown #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nepalingo with
|
| Latest commit: |
25bd49d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b2c1937.nepalingo.pages.dev |
| Branch Preview URL: | https://languagedropdown.nepalingo.pages.dev |
christikaes
reviewed
Jul 18, 2024
| "Newari": "newari", | ||
| "Tajpuriya": "tajpuriya", | ||
| "Maithili": "coming soon", | ||
| } as const |
There was a problem hiding this comment.
why not just make it a string? this object type seems a bit redundant. Why is as const needed?
christikaes
reviewed
Jul 18, 2024
|
|
||
|
|
||
| type LanguageContextProps = { | ||
| selectedLanguage: string | null | undefined; |
There was a problem hiding this comment.
do we need both null and undefined?
SansCaar
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made a language dropdown to change the language of the flashcards in future
made the header match the mockups and a lil bit