Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: misleading error logs in RobotState::setFromIKSubgroups() (backport #3263) #3267

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 24, 2025

Description

misleading log message for RobotState::setFromIKSubgroups() when checking consistency_limits size

before:

screenshot-20250123-160345

fixed:

fixed


This is an automatic backport of pull request #3263 done by [Mergify](https://mergify.com).

* Fix: misleading error logs

misleading log message for  RobotState::setFromIKSubgroups() when checking consistency_limits size

* fix clang-format

(cherry picked from commit 524ca4f)

# Conflicts:
#	moveit_core/robot_state/src/robot_state.cpp
@mergify mergify bot added the conflicts label Jan 24, 2025
Copy link
Author

mergify bot commented Jan 24, 2025

Cherry-pick of 524ca4f has failed:

On branch mergify/bp/humble/pr-3263
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 524ca4f15.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_core/robot_state/src/robot_state.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.38%. Comparing base (e893db5) to head (b7e4e83).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
moveit_core/robot_state/src/robot_state.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #3267      +/-   ##
==========================================
- Coverage   51.40%   51.38%   -0.01%     
==========================================
  Files         382      382              
  Lines       31896    31896              
==========================================
- Hits        16394    16388       -6     
- Misses      15502    15508       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit 8d89f73 into humble Jan 25, 2025
7 checks passed
@sea-bass sea-bass deleted the mergify/bp/humble/pr-3263 branch January 25, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants