-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[speex] Use native autotools for all triplets #26502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 55112eb54a1c4cfaec5dd2592a39cea72f78ed56 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 8904762..14397cc 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6846,7 +6846,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..4d70e0e 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "7767d6043727a6f09f8a5ee6a33b42d0dceea5ba",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
|
||
AC_MSG_CHECKING(for C99 variable-size arrays) | ||
-+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[ | ||
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this patch do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes an upstream typo which broke that test. Cf. xiph/speex#20.
Alternative to #26487 (comment).
What does your PR fix?
Use the native build system for all triplets. Fixes mingw builds.
Adds speexdsp dependency/feature control.
Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes