[speex] Build every triplets with CMake and added CMake config files #26487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869d..c7c153f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6838,7 +6838,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..21b8755 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "64f8faf78a155f020441207440e5da22aaa43081",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869d..c7c153f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6838,7 +6838,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..a59f784 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "394913cea6fddf43847d42fa73eb731cce1442eb",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869d..c7c153f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6838,7 +6838,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..2547b14 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "4c4de325e799efb2d5d857c389475a99cba9e80a",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869d..c7c153f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6838,7 +6838,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..fdddc46 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "c9e494dbe25cfa472e9f89b216f7e1b28993225c",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 88b1071e39f13b632644d9d953738d345a4ac055 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index ae7869d..c7c153f 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6838,7 +6838,7 @@
},
"speex": {
"baseline": "1.2.1",
- "port-version": 0
+ "port-version": 1
},
"speexdsp": {
"baseline": "1.2.1",
diff --git a/versions/s-/speex.json b/versions/s-/speex.json
index 092587c..dc38ed6 100644
--- a/versions/s-/speex.json
+++ b/versions/s-/speex.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "cc743c1d22cec3808f7c55da9bfae913cf78e065",
+ "version": "1.2.1",
+ "port-version": 1
+ },
{
"git-tree": "0520509fd60e20c5362959a7549dd29f7d04d54b",
"version": "1.2.1",
Adela0814
added
the
category:port-feature
|
Did you consider using the original build system for all triplets instead? I know it is slower on Windows, but having the buildsystem maintenance in vcpkg (and no tests!) is a problem in some other ports already. |
|
I have just tried it : it's completely broken with MSVC. I get build errors coming from everywhere. |
|
Looks like there was just a tiny showstopper: xiph/speex#20 Full alternative PR: #26502 |
|
Ok, closing this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds the package with CMake for every triplets
Added CMake config files
What does your PR fix?
None
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I am still working on this PR