[MRG] chore: change fixed L2 names in gui to L2/3 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoplata
changed the title
jasmainak
reviewed
Oct 18, 2024
| @@ -400,7 +400,7 @@ def __init__(self, theme_color="#802989", | |||
| button_color=self.layout['theme_color']) | |||
|
|
|||
| self.cell_type_radio_buttons = RadioButtons( | |||
| options=['L2 Pyramidal', 'L5 Pyramidal'], | |||
| options=['L2/3 Pyramidal', 'L5 Pyramidal'], | |||
There was a problem hiding this comment.
don't forget to update whats_new.rst so you can be credited in the next release
gtdang
requested changes
Oct 18, 2024
asoplata
force-pushed
the
iss904_gui_L23
branch
from
0b60b98 to
5033ce8
Compare
Note that this does not change the L2 names inherent in the `cell_types` which are loaded dynamically in the gui, such as shown here: jonescompneurolab#904 (comment)
asoplata
force-pushed
the
iss904_gui_L23
branch
from
5033ce8 to
7a374bf
Compare
Should squash this before pushing to master...
|
@gtdang I think I found where a simple string replace lets the read-in text in |
|
Resolves #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this does not change the L2 names inherent in the
cell_typeswhich are loaded dynamically in the gui, such as shown here: #904 (comment)