-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: Change GUI mentions of Layer 2 (L2) to Layer 2/3 #904
Labels
hnn-gui
HNN GUI
Comments
asoplata
added a commit
to asoplata/hnn-core
that referenced
this issue
Oct 18, 2024
Note that this does not change the L2 names inherent in the `cell_types` which are loaded dynamically in the gui, such as shown here: jonescompneurolab#904 (comment)
@asoplata pasting here as requested :) the cell properties widget output: gui.app_layout.left_sidebar.children[0].children[0].children[1].children[1].children[1] you can use the .get_state() method and look at the 'outputs'; e.g.,
|
asoplata
added a commit
to asoplata/hnn-core
that referenced
this issue
Oct 21, 2024
Note that this does not change the L2 names inherent in the `cell_types` which are loaded dynamically in the gui, such as shown here: jonescompneurolab#904 (comment)
asoplata
added a commit
to asoplata/hnn-core
that referenced
this issue
Oct 21, 2024
Note that this does not change the L2 names inherent in the `cell_types` which are loaded dynamically in the gui, such as shown here: jonescompneurolab#904 (comment)
gtdang
pushed a commit
that referenced
this issue
Oct 22, 2024
Note that this does not change the L2 names inherent in the `cell_types` which are loaded dynamically in the gui, such as shown here: #904 (comment)
Resolved from #907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
Currently, the
hnn-core
GUI only displays layer information for either "Layer 2" or "Layer 5". However, it is more scientifically accurate to use the term "Layer 2/3" instead of "Layer 2", since the former is closer to what we are simulating.Solution:
I think the original intention was to change literally where the GUI displays things like
layer2
such as here ( https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/gui/_viz_manager.py#L96 ) and, similarly, here ( https://github.com/jonescompneurolab/hnn-core/blob/master/hnn_core/viz.py#L330 ). This is trivial and I will have no problem changing similar things.However...
Greater Context:
This would also introduce a small amount of both visual and naming inconsistency. As (crudely) highlighted in the below screenshot, updating only the GUI plot titles for display would change the plot title on the right, but anything shown that pulls from a Network object or the canonical
cell_types
, such as on the left, is still going to showL2
.To manage this inconsistency, I can only think of three possibilities:
cell_type
names alone. We then add a note / clarification in the documents that says we useL2
etc., in the code for historical reasons, but that any time we say "layer 2" in any form, we really scientifically mean "layer 2 / 3". This is basically the same as what I said in the Solution above (assuming we don't already have a clarification that says that). Additionally, we could even have text warnings displayed on the GUI where relevant, like "Anything indicated by L2 is equivalent to Layers 2 / 3", though that feels hacky. Most domain experts using HNN will NOT be confused by the L2 / L23 naming, especially when we don't have separate L3 celltypes.L2Pyr_...
parameters will break, any code that parses the layer name would have to be checked, etc. I think this is a bad idea, but still wanted to bring it up just in case.cell_types
in the GUI but not in the actual data, but this is a terrible idea).I suggest we go with Option 1 above (minor changes only), unless someone wants to seriously discuss Option 2.
The text was updated successfully, but these errors were encountered: