Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starting mbon_stats #74

Merged
merged 11 commits into from
May 23, 2024
Merged

starting mbon_stats #74

merged 11 commits into from
May 23, 2024

Conversation

MathewBiddle
Copy link
Contributor

Starting to add the mbon_stats function to this library

@laurabrenskelle
@ocefpaf

@MathewBiddle
Copy link
Contributor Author

@ocefpaf this introduces pyobis as a dependency. I added to environment.yml but not the lock files. I assume that will break things.

@ocefpaf
Copy link
Member

ocefpaf commented May 22, 2024

@ocefpaf this introduces pyobis as a dependency. I added to environment.yml but not the lock files. I assume that will break things.

It won't break things but if when we do add a test for this functionality we need to update the conda-lock file with:

conda-lock --conda=micromamba -f environment.yml

then commit the new conda-lock file.

@MathewBiddle MathewBiddle marked this pull request as ready for review May 22, 2024 19:03
@MathewBiddle
Copy link
Contributor Author

@ocefpaf mind taking a look?

ocefpaf
ocefpaf reviewed May 22, 2024
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. I can take a better look tomorrow but I would not optimize or refactor it before adding some basic tests.

Let me know if you want to merge this one and work on tests, etc in another PR.

ioos_metrics/ioos_metrics.py Outdated Show resolved Hide resolved
ioos_metrics/ioos_metrics.py Outdated Show resolved Hide resolved
ioos_metrics/ioos_metrics.py Outdated Show resolved Hide resolved
@MathewBiddle
Copy link
Contributor Author

Thanks! Yeah, that sounds good. We'll need help with tests...

@MathewBiddle
adding test for mbon_stats
4745891 
moving test CI to environment.yml
MathewBiddle and others added 2 commits May 23, 2024 10:36
@MathewBiddle
testing columns
207dc9f 
clarifying documentation
@MathewBiddle @ocefpaf
Update ioos_metrics/ioos_metrics.py
94024f3 
Co-authored-by: Filipe <[email protected]>
@MathewBiddle
Copy link
Contributor Author

okay! We should be ready to merge! :)

@MathewBiddle MathewBiddle mentioned this pull request May 23, 2024
Closed
@MathewBiddle MathewBiddle linked an issue May 23, 2024 that may be closed by this pull request
Collect MBON dataset DOI, download, and use statistics from OBIS and GBIF API #69
Closed
@ocefpaf
Copy link
Member

ocefpaf commented May 23, 2024

okay! We should be ready to merge! :)

I don't have merge rights here but I agree! Merge away!!

@MathewBiddle
Copy link
Contributor Author

@laurabrenskelle mind merging?

@laurabrenskelle laurabrenskelle merged commit fb0aa66 into ioos:main May 23, 2024
3 checks passed
@MathewBiddle MathewBiddle deleted the mbon_stats branch May 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

Assignees
No one assigned
Labels
ioos-code-sprint-2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect MBON dataset DOI, download, and use statistics from OBIS and GBIF API
3 participants
@MathewBiddle @ocefpaf @laurabrenskelle