Rename the environment variables to the same as in Packer #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3deep5me
force-pushed
the
rename-proxmox-secret-names
branch
from
8e5066f to
9dfa557
Compare
|
I'm not so sure. Besides this being a breaking change, these are called Token ID and Secret in Proxmox VE. It would be confusing to call the secret the token. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52
Draft
not tested (have to set up my development environment and tools first)
Description of changes:
Renames the Variable
PROXMOX_TOKENtoPROXMOX_USERNAMERenames the Variable
PROXMOX_SECRETtoPROXMOX_TOKENThis should be easier to understand and is the same as in Packer which should prevent #52.
Testing performed: