Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROXMOX_TOKEN in CAPMOX is PROXMOX_SECRET in the Image-Builder which is error-prone #52

Closed
3deep5me opened this issue Jan 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@3deep5me
Copy link
Contributor

3deep5me commented Jan 6, 2024

I created an image with image-builder, the environment variable for the "secret-key" is PROXMOX_TOKEN.
In CAPMOX the same environment variable contains the "token-user".

During the clusterctl init the environment variable is preferred over the config-file, so i ended up to have an secret like this

apiVersion: v1
data:
  secret: M3OWRi
  token: M3OWRi
  url: aHqc29u

I would like to suggest to have the same naming as in the image-builder to save others the trouble shooting.
PROXMOX_USERNAME & PROXMOX_TOKEN

I should be able to create a PR for that - if desired.

@3deep5me 3deep5me added the enhancement New feature or request label Jan 6, 2024
@mcbenjemaa
Copy link
Member

Great Point.

The image builder vars are based on the packer plugin,
So, if we want to support the same naming, we will need to rename those, and this will be a Breaking change.

you're welcome to add this.

65278 pushed a commit that referenced this issue Jan 17, 2024
* Scan container images

* Skip upload step

* Add SECURITY.md

* Add issue template

---------

Co-authored-by: Mohamed Chiheb Ben Jemaa <[email protected]>
@65278
Copy link
Collaborator

65278 commented Mar 6, 2024

We should at least get documentation in for this in CAPMOX v0.4.0.

@wikkyk
Copy link
Collaborator

wikkyk commented Apr 18, 2024

See #173 and #54 (comment) - we decided that remaining consistent with Proxmox VE is more important than being consistent with Packer.

@wikkyk wikkyk closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants