Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4014: Use method(not field) access in client #4015

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 25, 2023

Description

Linked issue

Closes #4014

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 25, 2023
@mversic mversic force-pushed the transparent_build_fix branch from b71a715 to dce0dcd Compare October 25, 2023 09:31
@coveralls
Copy link

coveralls commented Oct 25, 2023

Pull Request Test Coverage Report for Build 6640420272

  • 1 of 10 (10.0%) changed or added relevant lines in 3 files are covered.
  • 6906 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.6%) to 55.884%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client_cli/src/main.rs 0 3 0.0%
client/src/client.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
client/src/lib.rs 1 0.0%
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 96.0%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
Totals Coverage Status
Change from base Build 5423219773: -3.6%
Covered Lines: 22082
Relevant Lines: 39514

💛 - Coveralls

@mversic mversic force-pushed the transparent_build_fix branch from dce0dcd to 5c9a8ab Compare October 25, 2023 12:33
@Arjentix Arjentix self-assigned this Oct 26, 2023
data_model/src/query/mod.rs Show resolved Hide resolved
@DCNick3 DCNick3 self-assigned this Oct 26, 2023
@mversic mversic merged commit 8018332 into hyperledger-iroha:iroha2-dev Oct 26, 2023
9 checks passed
@mversic mversic deleted the transparent_build_fix branch October 26, 2023 12:33
0x009922 added a commit to 0x009922/iroha-javascript that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants