Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query params to Vec is unintuitive #4017

Closed
mversic opened this issue Oct 26, 2023 · 1 comment
Closed

Query params to Vec is unintuitive #4017

mversic opened this issue Oct 26, 2023 · 1 comment
Assignees
@VAmuzing
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Oct 26, 2023 

          Not introduced in this PR, but the conversion of `Pagination` and `Sorting` structs to `Vec` is a bit unintuitive.. I feel like explicitly naming it something like `into_request_params`.

Maybe even make it into a as_request_params & make it accept a reference (it's cloned here anyways).

Originally posted by @DCNick3 in #4015 (comment)
@mversic mversic mentioned this issue Oct 26, 2023
Merged
5 tasks
@mversic mversic added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 30, 2023
@mversic mversic mentioned this issue Nov 30, 2023
Closed
@VAmuzing
Copy link
Contributor

Made the changes in #4023, now it consumes self and the methods names are into_query_parameters

@VAmuzing VAmuzing self-assigned this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VAmuzing VAmuzing

Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VAmuzing @mversic