Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-11236 upgrade to use V5 of the GDS frontend #1461

Merged
merged 12 commits into from
Jan 10, 2025
Merged

VIH-11236 upgrade to use V5 of the GDS frontend #1461

merged 12 commits into from
Jan 10, 2025

Conversation

shaed-parkar
Copy link
Contributor

@shaed-parkar shaed-parkar commented Jan 8, 2025 •
edited
Loading

Jira link

VIH-11236

Change description

  • update prettier version
    • this has caused quite a few files to be affected due to additional default rules
  • upgrade to use V5 of the GDS frontend
  • remove unused png files
  • replace use of img files with font-awesome elements
  • import assets from gds package using the web builder instead of manually managing the assets

@shaed-parkar shaed-parkar requested review from a team as code owners January 8, 2025 10:36
@shaed-parkar shaed-parkar mentioned this pull request Jan 8, 2025
Closed
@shaed-parkar shaed-parkar force-pushed the feature/VIH-11236_upgrade_gds_lib branch from 2b2b9f0 to dd839bb Compare January 8, 2025 11:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@shaed-parkar shaed-parkar merged commit 7aa184b into master Jan 10, 2025
10 of 11 checks passed
@shaed-parkar shaed-parkar deleted the feature/VIH-11236_upgrade_gds_lib branch January 10, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmalone ronaldmalone ronaldmalone approved these changes

@oliver-scott oliver-scott oliver-scott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaed-parkar @oliver-scott @ronaldmalone