VIH-0000 WIP upgrade GDS to v5+ #1447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaed-parkar
force-pushed
the
upgrade_gds
branch
from
b61f4e3 to
cd08f02
Compare
* added clearUsers function * test fix * added test * Update justice-users.service.spec.ts * Update justice-users.service.spec.ts * Update justice-users.service.spec.ts * Update justice-users.service.spec.ts * Update justice-users.service.spec.ts * updated test --------- Co-authored-by: William Craig <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
replaced by #1461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
TBC
Change description
Upgrade GDS library to v5
This pull request includes updates to dependencies, adjustments to asset paths, and minor style changes across various components. The most important changes include downgrading the
SonarAnalyzer.CSharppackage, updating thegovuk-frontendpackage and its usage, and modifying button classes for consistency.Dependency updates:
AdminWebsite/AdminWebsite/ClientApp/package.json: Updated@ministryofjustice/frontendto^3.0.3,govuk-frontendto^5.5.0, andlaunchdarkly-js-client-sdkto^3.5.0.Asset path adjustments:
AdminWebsite/AdminWebsite/ClientApp/angular.json: Changed font asset path fromnode_modules/govuk-frontend/govuk/assets/fontstonode_modules/govuk-frontend/dist/govuk/assets/fonts..scssfiles: Updated import paths fromgovuk-frontend/govuk/basetogovuk-frontend/dist/govuk/base.Button class consistency:
.htmlfiles: Replacedhmcts-button--secondarywithgovuk-button--secondaryfor cancel buttons.