DTSPB-4395 added new template id to caveat #2944
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -246,7 +246,7 @@ notifications: | |
| applicationReceivedPaperFormCaseworker: "01bfc52c-0850-4155-ae03-e6d638286288" | ||
| documentReceived: "24161fba-65f5-4384-9c4f-ef75f4a5c666" | ||
| caseStopped: "60b95b7c-0a76-4608-b549-b3a579cfa3d0" | ||
| caseStoppedCaveat: "d5084257-f475-415a-b7d0-2427b5c580b1" | ||
tom-saunders-cts marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| grantIssued: "53374eda-d7a1-4651-bd29-65672ac0137a" | ||
| grantReissued: "b1977c1f-b998-48c3-b848-bc5d86c58b2e" | ||
| generalCaveatMessage: "afadf00e-c224-4da0-a6dc-fb47a2e5db67" | ||
|
|
@@ -271,7 +271,7 @@ notifications: | |
| applicationReceivedPaperFormCaseworker: "01bfc52c-0850-4155-ae03-e6d638286288" | ||
| documentReceived: "e618dce9-405e-45a5-86e8-06d792336f2f" | ||
| caseStopped: "9e93a9c8-0246-4a95-b792-1c02da4bed4e" | ||
| caseStoppedCaveat: "d5084257-f475-415a-b7d0-2427b5c580b1" | ||
| grantIssued: "0ba9fc37-acfc-47ee-b1ca-f630c921f14d" | ||
| grantReissued: "9b0e4091-8c94-41bc-8e6c-de4bc211f68f" | ||
| generalCaveatMessage: "afadf00e-c224-4da0-a6dc-fb47a2e5db67" | ||
|
|
@@ -297,7 +297,7 @@ notifications: | |
| applicationReceivedPaperFormCaseworker: "22c81233-a213-4520-b6bc-896fe8f6988a" | ||
| documentReceived: "39b7cef5-8202-479e-9f1e-86a76f964221" | ||
| caseStopped: "80b576b4-1a33-4920-837a-f2904784c9e2" | ||
| caseStoppedCaveat: "4aec6fa3-7e76-406a-9953-2f12d5d29f81" | ||
|
There was a problem hiding this comment.
new appears to only have changed the text in english, and the modified text doesn't match what is in the ticket There was a problem hiding this comment. there are some other weird handling parts of these messages, but i think we can handle those outside the scope of the PR(?) - i have added a comment in the ticket to flag them and we can follow up through that since we can update the template without a PR There was a problem hiding this comment. Thanks Tom good catch . |
||
| grantIssued: "7ce2c312-e4ec-4e63-a48b-82180d9a4160" | ||
| grantReissued: "c4436722-33df-4945-af93-b4d84525b4e6" | ||
| generalCaveatMessage: "d2b33c5b-0c65-4472-b26f-9352de5538ba" | ||
|
|
@@ -320,7 +320,7 @@ notifications: | |
| applicationReceivedPaperFormCaseworker: "22c81233-a213-4520-b6bc-896fe8f6988a" | ||
| documentReceived: "83f93f41-58a1-44f2-a9c4-d20d545b7528" | ||
| caseStopped: "a767a0bd-4acc-413e-b510-5a71d24daf85" | ||
| caseStoppedCaveat: "4aec6fa3-7e76-406a-9953-2f12d5d29f81" | ||
| grantIssued: "0ba9fc37-acfc-47ee-b1ca-f630c921f14d" | ||
| grantReissued: "9b0e4091-8c94-41bc-8e6c-de4bc211f68f" | ||
| generalCaveatMessage: "afadf00e-c224-4da0-a6dc-fb47a2e5db67" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we update the test(s) where this was failing to improve their failure messaging in case we have the same issue in the future? (given the error message was
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>this doesn't actually provide any useful information on why it is failing.)