DTSPB-4395 added new template id to caveat #2944

abbasiTahir · 2025-01-03T13:01:12Z

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/DTSPB-4395

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

github-actions · 2025-01-03T13:01:44Z

CCD diff report

No change

src/main/resources/application.properties

src/main/resources/application.yml

tom-saunders-cts · 2025-01-03T13:16:14Z

src/main/resources/application.yml

-          caseStoppedCaveat: "1fde1860-b827-45e7-b430-1406f74beb93"
+          caseStoppedCaveat: "4aec6fa3-7e76-406a-9953-2f12d5d29f81"


old https://www.notifications.service.gov.uk/services/4809d6a8-a10b-405d-88eb-1fee9b3042e3/templates/1fde1860-b827-45e7-b430-1406f74beb93

new https://www.notifications.service.gov.uk/services/4809d6a8-a10b-405d-88eb-1fee9b3042e3/templates/4aec6fa3-7e76-406a-9953-2f12d5d29f81

new appears to only have changed the text in english, and the modified text doesn't match what is in the ticket

there are some other weird handling parts of these messages, but i think we can handle those outside the scope of the PR(?) - i have added a comment in the ticket to flag them and we can follow up through that since we can update the template without a PR

Thanks Tom good catch .

github-actions · 2025-01-03T15:10:22Z

CCD diff report

No change

tom-saunders-cts

the alternative would be to directly update the existing template and make no change, but i think this is probably the better solution as we can track and control when that change goes live

github-actions · 2025-01-06T10:51:47Z

CCD diff report

No change

github-actions · 2025-01-06T10:52:18Z

CCD diff report

No change

FeliTam · 2025-01-06T12:10:10Z

src/contractTest/resources/application.yml

@@ -286,7 +286,7 @@ notifications:
          applicationReceivedPaperFormCaseworker: "22c81233-a213-4520-b6bc-896fe8f6988a"
          documentReceived: "83f93f41-58a1-44f2-a9c4-d20d545b7528"
          caseStopped: "a767a0bd-4acc-413e-b510-5a71d24daf85"
-          caseStoppedCaveat: "937291a0-c0ae-40a4-a8cf-46a3452faff0"
+          caseStoppedCaveat: "d5084257-f475-415a-b7d0-2427b5c580b1"


this should use welsh version template

github-actions · 2025-01-06T12:43:35Z

CCD diff report

No change

github-actions · 2025-01-06T14:21:44Z

CCD diff report

No change

tom-saunders-cts · 2025-01-06T14:14:02Z

...est/java/uk/gov/hmcts/probate/functional/notifications/SolBaCcdServiceNotificationTests.java

-    private static final String REGISTRY_NO = "0113 389 6133";
+    private static final String REGISTRY_NO = " 0300 303 0648";


can we update the test(s) where this was failing to improve their failure messaging in case we have the same issue in the future? (given the error message was org.opentest4j.AssertionFailedError: expected: <true> but was: <false> this doesn't actually provide any useful information on why it is failing.)

github-actions · 2025-01-07T15:31:18Z

CCD diff report

No change

hmcts-jenkins-j-to-z · 2025-01-15T11:30:45Z

Plan Result (aat)

No changes. Your infrastructure matches the configuration.

hmcts-jenkins-j-to-z · 2025-01-15T11:31:15Z

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

github-actions · 2025-01-15T14:18:42Z

CCD diff report

No change

DTSPB-4935 added new template id

8e0b5e7

tom-saunders-cts reviewed Jan 3, 2025

View reviewed changes

src/main/resources/application.properties Outdated Show resolved Hide resolved

hmcts-jenkins-j-to-z bot deployed to preview January 3, 2025 13:10 View deployment

hmcts-jenkins-j-to-z bot added ns:probate prd:probate rel:probate-back-office-pr-2944 labels Jan 3, 2025

tom-saunders-cts reviewed Jan 3, 2025

View reviewed changes

src/main/resources/application.yml Show resolved Hide resolved

tom-saunders-cts reviewed Jan 3, 2025

View reviewed changes

DTSPB-4935 reverted the application.properties

1b12765

hmcts-jenkins-j-to-z bot deployed to preview January 3, 2025 15:20 View deployment

tom-saunders-cts previously approved these changes Jan 3, 2025

View reviewed changes

hmcts-jenkins-j-to-z bot deployed to preview January 3, 2025 16:20 View deployment

abbasiTahir added the nightly nightlytest label Jan 6, 2025

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 09:38 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 10:00 View deployment

DTSPB-4935 fixed the funtional test

4a7a0bc

abbasiTahir dismissed tom-saunders-cts’s stale review via 4a7a0bc January 6, 2025 10:51

Merge branch 'master' into DTSPB-4935-Update-contact-details-on-Caveat

b92dc9d

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 11:00 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 11:43 View deployment

FeliTam reviewed Jan 6, 2025

View reviewed changes

abbasiTahir removed the nightly nightlytest label Jan 6, 2025

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 12:23 View deployment

DTSPB-4935 corrected the walesh translation .

26ba24b

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 12:53 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 6, 2025 14:29 View deployment

tom-saunders-cts reviewed Jan 7, 2025

View reviewed changes

Merge branch 'master' into DTSPB-4935-Update-contact-details-on-Caveat

7aac275

hmcts-jenkins-j-to-z bot deployed to preview January 7, 2025 15:42 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 13, 2025 10:36 View deployment

elifetoplu added nightly nightlytest enable_keep_helm labels Jan 13, 2025

hmcts-jenkins-j-to-z bot deployed to preview January 13, 2025 10:52 View deployment

FeliTam changed the title ~~DTSPB-4935 added new template id to caveat~~ DTSPB-4395 added new template id to caveat Jan 13, 2025

hmcts-jenkins-j-to-z bot deployed to preview January 14, 2025 15:51 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 14, 2025 16:36 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 14, 2025 17:38 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 14, 2025 18:20 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 15, 2025 08:43 View deployment

hmcts-jenkins-j-to-z bot deployed to preview January 15, 2025 10:51 View deployment

elifetoplu removed nightly nightlytest enable_keep_helm labels Jan 15, 2025

hmcts-jenkins-j-to-z bot added the aat/no-changes label Jan 15, 2025

hmcts-jenkins-j-to-z bot added the prod/no-changes label Jan 15, 2025

hmcts-jenkins-j-to-z bot deployed to preview January 15, 2025 11:31 View deployment

Merge branch 'master' into DTSPB-4935-Update-contact-details-on-Caveat

1905a3c

hmcts-jenkins-j-to-z bot deployed to preview January 15, 2025 14:27 View deployment

FeliTam approved these changes Jan 15, 2025

View reviewed changes

abbasiTahir merged commit a31b49f into master Jan 15, 2025
8 checks passed

abbasiTahir deleted the DTSPB-4935-Update-contact-details-on-Caveat branch January 15, 2025 15:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DTSPB-4395 added new template id to caveat #2944

DTSPB-4395 added new template id to caveat #2944

abbasiTahir commented Jan 3, 2025

github-actions bot commented Jan 3, 2025

tom-saunders-cts Jan 3, 2025

abbasiTahir Jan 3, 2025

tom-saunders-cts Jan 3, 2025

abbasiTahir Jan 3, 2025

github-actions bot commented Jan 3, 2025

tom-saunders-cts left a comment

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

FeliTam Jan 6, 2025

abbasiTahir Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

tom-saunders-cts Jan 6, 2025

github-actions bot commented Jan 7, 2025

hmcts-jenkins-j-to-z bot commented Jan 15, 2025

hmcts-jenkins-j-to-z bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

		caseStoppedCaveat: "1fde1860-b827-45e7-b430-1406f74beb93"
		caseStoppedCaveat: "4aec6fa3-7e76-406a-9953-2f12d5d29f81"

		private static final String REGISTRY_NO = "0113 389 6133";
		private static final String REGISTRY_NO = " 0300 303 0648";

DTSPB-4395 added new template id to caveat #2944

DTSPB-4395 added new template id to caveat #2944

Conversation

abbasiTahir commented Jan 3, 2025

JIRA link (if applicable)

Change description

github-actions bot commented Jan 3, 2025

CCD diff report

tom-saunders-cts Jan 3, 2025

Choose a reason for hiding this comment

abbasiTahir Jan 3, 2025

Choose a reason for hiding this comment

tom-saunders-cts Jan 3, 2025

Choose a reason for hiding this comment

abbasiTahir Jan 3, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2025

CCD diff report

tom-saunders-cts left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025

CCD diff report

github-actions bot commented Jan 6, 2025

CCD diff report

FeliTam Jan 6, 2025

Choose a reason for hiding this comment

abbasiTahir Jan 6, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025

CCD diff report

github-actions bot commented Jan 6, 2025

CCD diff report

tom-saunders-cts Jan 6, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 7, 2025

CCD diff report

hmcts-jenkins-j-to-z bot commented Jan 15, 2025

Plan Result (aat)

hmcts-jenkins-j-to-z bot commented Jan 15, 2025

Plan Result (prod)

github-actions bot commented Jan 15, 2025

CCD diff report