Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating images design updates #201

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Floating images design updates #201

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1508aa
Floating-images: update styles to match new designs
schooolman Mar 29, 2024
abfc95d
Floating-images: update primary, secondary, and tertiary colors
schooolman Mar 29, 2024
4c9326f
Floating-images: updates to button styles and some margins.
schooolman Mar 29, 2024
8cac776
Floating-images: moving button styles out of block into base style file.
schooolman Apr 1, 2024
475748a
floating-images-design-updates: pulling in font updates and fixing me…
schooolman Apr 3, 2024
66fdc98
Merge branch 'main' of github.com:hlxsites/hsf-commonmoves into float…
schooolman Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 41 additions & 7 deletions blocks/floating-images/floating-images.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@
}

.block.floating-images > div {
background-color: var(--secondary-color);
display: flex;
flex-direction: column-reverse;
padding-top: 1em;
min-height: 530px;
}


.block.floating-images .image {
position: relative;
padding: 1.5em 0;
}

.block.floating-images .image img {
Expand All @@ -25,10 +24,23 @@
max-width: 100%;
}

.block.floating-images .content {
margin: 30px 0;
}

.block.floating-images .content h2 {
color: var(--primary-color);
letter-spacing: normal;
margin-bottom: 0.5em;
padding: 0 16px;
text-align: left;
text-transform: uppercase;
}

.block.floating-images .content p {
color: var(--primary-color);
padding: 0 16px;
margin-bottom: 13px;
}

.block.floating-images .content ul {
Expand All @@ -43,14 +55,32 @@
line-height: var(--line-height-m);
}

.block.floating-images p.button-container {
text-align: center;
.block.floating-images p .button {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check this and compare it to the use of p.button-container a and/or p.button-container a.primary throughout the site, if we can just update those, that'd be better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look and it seems like this is the main primary button style of the new design, so I moved those button styles to the main styles.css file.

background-color: transparent;
border: 1px solid var(--primary-color);
color: var(--primary-color);
font-size: var(--heading-font-size-xs);
font-weight: var(--font-weight-bold);
letter-spacing: var(--letter-spacing-m);
line-height: 1;
padding: 7px 25px;
}

.block.floating-images p .button:hover {
background-color: var(--primary-color);
color: var(--secondary-color);
}

.block.floating-images p .button:focus {
background-color: var(--primary-color);
color: var(--secondary-color);
outline: var(--primary-color) solid 2px;
outline-offset: 3px;
}

@media screen and (min-width: 900px) {
.block.floating-images > div {
flex-direction: row;
column-gap: 15px;
align-items: center;
}

Expand Down Expand Up @@ -102,7 +132,11 @@


@media screen and (min-width: 1200px) {
.block.floating-images > div {
column-gap: 30px;
.block.floating-images .content h2 {
padding: 0 80px;
}

.block.floating-images .content p {
padding: 0 80px;
}
}
4 changes: 3 additions & 1 deletion styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@

:root {
/* Colors */
--primary-color: #552448;
--primary-color: #670038;
--secondary-color: #aa979c;
--tertiary-color: #f5f1f2;
--primary-color-lighten: rgba(98 98 121 / 12.5%);
--primary-color-svg-filter: invert(18%) sepia(17%) saturate(1944%) hue-rotate(264deg) brightness(93%) contrast(95%);
--color-tertiary: #eae3d4;
Expand Down
Loading