Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating images design updates #201

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

schooolman
Copy link
Collaborator

Updating the styles for the floating-image block to match the new site design. Have also updated primary, secondary, and tertiary colors in the root styles.

Test URLs:

@schooolman schooolman requested a review from bstopp March 29, 2024 16:51
Copy link

aem-code-sync bot commented Mar 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Mar 29, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -43,14 +55,32 @@
line-height: var(--line-height-m);
}

.block.floating-images p.button-container {
text-align: center;
.block.floating-images p .button {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check this and compare it to the use of p.button-container a and/or p.button-container a.primary throughout the site, if we can just update those, that'd be better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look and it seems like this is the main primary button style of the new design, so I moved those button styles to the main styles.css file.

@aem-code-sync aem-code-sync bot temporarily deployed to floating-images-design-updates April 1, 2024 19:42 Inactive
display: inline-block;
padding: .75em 1.5em;
font-family: var(--font-family-proxima);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still Proxima?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning on updating the fonts in a separate pull request, and then updating all --font-family-proxima to use the new font, and changing the variable name to --font-family-primary

I can do that in this PR if you would prefer though.

@aem-code-sync aem-code-sync bot temporarily deployed to floating-images-design-updates April 3, 2024 15:42 Inactive
@schooolman schooolman merged commit 7e989e5 into main Apr 3, 2024
2 checks passed
@bstopp bstopp deleted the floating-images-design-updates branch May 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants