-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating images design updates #201
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
@@ -43,14 +55,32 @@ | |||
line-height: var(--line-height-m); | |||
} | |||
|
|||
.block.floating-images p.button-container { | |||
text-align: center; | |||
.block.floating-images p .button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this and compare it to the use of p.button-container a
and/or p.button-container a.primary
throughout the site, if we can just update those, that'd be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look and it seems like this is the main primary button style of the new design, so I moved those button styles to the main styles.css file.
styles/styles.css
Outdated
display: inline-block; | ||
padding: .75em 1.5em; | ||
font-family: var(--font-family-proxima); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still Proxima?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning on updating the fonts in a separate pull request, and then updating all --font-family-proxima
to use the new font, and changing the variable name to --font-family-primary
I can do that in this PR if you would prefer though.
…ing-images-design-updates
Updating the styles for the floating-image block to match the new site design. Have also updated primary, secondary, and tertiary colors in the root styles.
Test URLs: