Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LCD output and add translations #8

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Fix LCD output and add translations #8

merged 9 commits into from
Aug 30, 2024

Conversation

3d-gussner
Copy link

No description provided.

@3d-gussner
Fix LCD output
c1360d7 
Configuration->HW Setup->Checks showed `a`

MSG_FILAMENT `Filament` can only be 8 chars long and only ES and IT had `Filemanto` as translation.
But as ES the `o` in `Filamento` was overwritten by `[Estricto]` I removed the MSG_FILAMENT to be translated.
Saves few bytes.
@3d-gussner
Add missing translations
b353f1f 
Used `trans -b :cs+de+es+fr+hr+hu+it+nl+no+pl+ro+sk+sv "<text>"` to translate
Looked at pre-translated text to reuse as much as possible.
@3d-gussner 3d-gussner mentioned this pull request Aug 26, 2024
Merged
@3d-gussner
Copy link
Author

3d-gussner commented Aug 26, 2024 •
edited
Loading

Please verify and approve the new translations. Remember that the message is limited to 20 characters and 3 rows,

ErwanAliasr1
ErwanAliasr1 approved these changes Aug 26, 2024
View reviewed changes
Copy link

@ErwanAliasr1 ErwanAliasr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR is 🆗

arekm
arekm approved these changes Aug 26, 2024
View reviewed changes
Copy link

@arekm arekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PL is OK.

@Ro3Deee
Copy link

Ro3Deee commented Aug 26, 2024

@leptun, for Romanian:
Instead "Nu există filament încărcat" I'd use "Filamentul nu este încărcat" sau "Filamentul nu este detectat"

@3d-gussner
Copy link
Author

@leptun, for Romanian: Instead "Nu există filament încărcat" I'd use "Filamentul nu este încărcat" sau "Filamentul nu este detectat"

Thanks @petrubecheru @Hauzman. Which is the preferred one?

  1. Filamentul nu este încărcat 🎉
  2. Filamentul nu este detectat ❤️

@3d-gussner
Update Romainian translations
e90b536 
Thanks to @petrubecheru and @Hauzman
stelgenhof
stelgenhof suggested changes Aug 26, 2024
View reviewed changes
lang/po/Firmware_nl.po Outdated Show resolved Hide resolved
gudnimg
gudnimg approved these changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@gudnimg gudnimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :) I’ll wait a bit for translators to review before merging.

@AttilaSVK
Copy link

Hungarian should be: "Nincs befűzve filament. Folytassam?" and "Nincs befűzve filament. Nyomtatás megállítva."

DRracer
DRracer reviewed Aug 28, 2024
View reviewed changes
lang/po/Firmware_cs.po Outdated Show resolved Hide resolved
DRracer
DRracer reviewed Aug 28, 2024
View reviewed changes
lang/po/Firmware_cs.po Outdated Show resolved Hide resolved
@3d-gussner
Copy link
Author

Hi
🇭🇷 @Prime1910 @PRPA041
🇸🇰 @ingbrzy @shatter136
🇸🇪 @Painkiller56
🇳🇴 @OS-kar @trondkla

Can you please let me know if you will be able to review the changes until end of this week? Also please let me know if you are still interested in reviewing the community translations. If not, I will not ask you anymore and will NOT translate new messages anymore or use "faulty" computer based translations instead.

shatter136
shatter136 reviewed Aug 28, 2024
View reviewed changes
Copy link

@shatter136 shatter136 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Sorry. In _sk, I would rather write "Nie je vložený filament. ... "
And please keep us still in the loop. Thank you.

ingbrzy
ingbrzy suggested changes Aug 28, 2024
View reviewed changes
lang/po/Firmware_sk.po Outdated Show resolved Hide resolved
lang/po/Firmware_sk.po Outdated Show resolved Hide resolved
@3d-gussner
Update Slovak translation
b9b32b0 
Thanks to @ingbrzy @shatter136
@3d-gussner
Update Community translation list
56de4bf 
- Croatian, Swedish and Norwegian are inactive since the last few translation review requests have not been done
@gudnimg gudnimg merged commit af6fbb1 into gudnimg:improve-missing-filament Aug 30, 2024
3 checks passed
@3d-gussner 3d-gussner deleted the MK3_fix_PR4727 branch August 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DRracer DRracer DRracer left review comments

@shatter136 shatter136 shatter136 left review comments

@wavexx wavexx wavexx left review comments

@ingbrzy ingbrzy ingbrzy requested changes

@stelgenhof stelgenhof stelgenhof requested changes

@gudnimg gudnimg gudnimg approved these changes

@ErwanAliasr1 ErwanAliasr1 ErwanAliasr1 approved these changes

@arekm arekm arekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.